WizardNavigationButtons everywhere - Part 2#1054
Merged
Arnei merged 6 commits intoopencast:mainfrom Jan 23, 2025
Merged
Conversation
Some of our create modal were not consistently using the WizardNavigationButtons component. This patch changes that, thereby removing a bunch of duplicated code.
Slightly generalizes the "WizardNavigationButtons" component, so that it can be used in more modals than just the create modals. This should further reduce code duplication.
Contributor
|
This pull request has conflicts ☹ |
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/1054/2025-01-23_09-24-11/ . |
Arnei
force-pushed
the
wizardnavigationbuttons-everywhere-part-2
branch
from
6e492e1 to
f4cc68e
Compare
Arnei
force-pushed
the
wizardnavigationbuttons-everywhere-part-2
branch
from
f4cc68e to
38a0b11
Compare
gregorydlogan
approved these changes
Jan 20, 2025
Contributor
|
This pull request has conflicts ☹ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly generalizes the "WizardNavigationButtons" component, so that it can be used in more modals than just the create modals. This should further reduce code duplication.
Includes and supersedes #832. I elected to create a new PR instead of updating the old one since the new changes are more broad and thus potentially more controversial than those of the previous PR.
How to test this
Can be tested as usual.