Revert PR #1043 "Update react-router to 7.1.1"#1083
Revert PR #1043 "Update react-router to 7.1.1"#1083Arnei wants to merge 5 commits intoopencast:mainfrom
Conversation
Reverts PR opencast#1043. The PR seems to have caused problems with table filtering, which are fixed by reverting it. The issue in question is that clicking on a series name in the series table will not result in a properly filtered events table anymore.
Arnei
added
type:bug
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1083/2025-02-11_09-58-48/ . |
Arnei
changed the title
|
This pull request has conflicts ☹ |
1 similar comment
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
This doesn't seem to be working for me. The filter only gets applied sometimes, and when it does, it still takes a few seconds to display the right events. Bildschirmaufnahme.2025-02-07.um.16.05.56.movAnd just as a side note for anyone else testing this branch, I had to take some extra steps before I could do so: |
|
Try as I might, I cannot reproduce your flukes. Is there any additional information to be had (in the webconsole etc.)? Filters not being applied instantly is arguably a different issue. |
|
I just tried again, with the same outcome. There are no failed requests or errors in the console. I am on Node.js v20.18.2, if that is of any importance. Also agree that filters not being applied instantly is another issue, it's just something that becomes apparent when testing these. |
|
This pull request has conflicts ☹ |
Arnei
force-pushed
the
revert-react-router-7.1.1
branch
from
8248cc1 to
673b26e
Compare
Includes opencast#980, supersedes opencast#1083. Should achieve the same thing as opencast#1083, but without reverting to older dependency versions. Meaning clicking on a series name in the series table should bring up the events table with the series filter set. Including opencast#980 as it helps in achieving this.
Includes opencast#980, supersedes opencast#1083. Should achieve the same thing as opencast#1083, but without reverting to older dependency versions. Meaning clicking on a series name in the series table should bring up the events table with the series filter set. Including opencast#980 as it helps in achieving this.
|
Closing this in favor #1111. |
2 participants
Reverts PR #1043, specifically commit a4097a5. The PR seems to have caused problems with table filtering, which are fixed by reverting it. The issue in question is that clicking on a series name in the series table will not result in a properly filtered events table anymore. See also #1043 (comment)
How to test this
Can be tested as usual. Make sure to run
npm install.