Skip to content

Reduce duplicate code for table action dropdown#1114

Merged
geichelberger merged 5 commits intoopencast:mainfrom
Arnei:reduce-duplicate-code-tableactions
Mar 24, 2025
Merged

Reduce duplicate code for table action dropdown#1114
geichelberger merged 5 commits intoopencast:mainfrom
Arnei:reduce-duplicate-code-tableactions

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Feb 21, 2025

Creates a new component for table action dropdowns. This should result in more readable code and make it easier to
introduce the component into other tables, should we ever need to.

How to test this

Can be tested as usual. The delete modal not opening is fixed by #1115.

Creates a new component for table action dropdowns. This should result
in more readable code and make it easier to
introduce the component into other tables, should we ever need to.
@Arnei Arnei added the type:code-enhancement Internal improvements to the codebase label Feb 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1114

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1114

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 21, 2025

This pull request is deployed at test.admin-interface.opencast.org/1114/2025-03-20_12-06-09/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Copy Markdown
Contributor

@ferishili ferishili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arnei,
Unfortunately, the delete action from the dropdown does not work properly.
However codewise looks good!

@Arnei
Copy link
Copy Markdown
Member Author

Arnei commented Mar 13, 2025

As mentioned in the initial post, the delete action not opening is fixed by PR #1115. I'll merge that into this branch once main is not broken anymore.

Comment thread src/components/shared/TableActionDropdown.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Copy Markdown
Contributor

@ferishili ferishili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arnei, LGTM

@ferishili ferishili requested a review from geichelberger March 24, 2025 06:28
Copy link
Copy Markdown
Contributor

@geichelberger geichelberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geichelberger geichelberger merged commit 225a736 into opencast:main Mar 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:code-enhancement Internal improvements to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants