Skip to content

Fix unique key error in NavBar#1116

Merged
geichelberger merged 1 commit intoopencast:mainfrom
Arnei:navbar-unique-key-error
Mar 4, 2025
Merged

Fix unique key error in NavBar#1116
geichelberger merged 1 commit intoopencast:mainfrom
Arnei:navbar-unique-key-error

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Feb 21, 2025

NavBar did not correctly key its links. This patch fixes that.

How to test this

Can be tested as usual. Observe if the unique key error in the webconsole disappears.

NavBar did not correctly key its links. This patch fixes that.
@Arnei Arnei added the type:bug Something isn't working label Feb 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1116

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1116

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1116/2025-02-21_15-16-34/ .
It might take a few minutes for it to become available.

Copy link
Copy Markdown
Contributor

@geichelberger geichelberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geichelberger geichelberger self-assigned this Mar 4, 2025
@geichelberger geichelberger merged commit d741f57 into opencast:main Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants