Skip to content

Restore table checkboxes on load#1139

Merged
gregorydlogan merged 1 commit intoopencast:mainfrom
Arnei:restore-table-checkboces-on-load
Mar 12, 2025
Merged

Restore table checkboxes on load#1139
gregorydlogan merged 1 commit intoopencast:mainfrom
Arnei:restore-table-checkboces-on-load

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Mar 11, 2025

Fixes #1136.
Table checkboxes were not rendered upon initial load. This patch fixes that.

How to test this

Can be tested as usual. Tables should again always render the selection checkboxes (if applicable for that table). The reset button in the edit table view modal should also continue to work.

Fixes opencast#1136.
Table checkboxes were not rendered upon initial load.
This patch fixes that.
@Arnei Arnei added the type:bug Something isn't working label Mar 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1139

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1139

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1139/2025-03-11_08-47-26/ .
It might take a few minutes for it to become available.

Copy link
Copy Markdown
Contributor

@NadiaUoM NadiaUoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question. Why you have added " | " on line no. 73? Because without adding this still checkbox are getting loaded.

@eduardklinger
Copy link
Copy Markdown

Just a small question. Why you have added " | " on line no. 73? Because without adding this still checkbox are getting loaded.

This added an empty string ("") to the types, because the default value was changed to "", which was not included in type Resource. The | just connects the empty string with the rest of the string values.

Copy link
Copy Markdown

@eduardklinger eduardklinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default resource value "events" prevented updating the multiSelect value on the first events table load.

Setting the default value to "" triggers updating the multiSelect value, which renders the checkboxes.

@Arnei
Copy link
Copy Markdown
Member Author

Arnei commented Mar 11, 2025

Arguably we should just make sure that multiSelect is set correctly on first table load, but this also works and removes the assumption that "events" is the first table we load, so shrug.

Thanks for reviewing!

@gregorydlogan gregorydlogan merged commit 45dcf37 into opencast:main Mar 12, 2025
@gregorydlogan gregorydlogan self-assigned this Mar 12, 2025
@Arnei Arnei mentioned this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Events table checkboxes have disappeared

4 participants