Skip to content

Improve phrasing of warning when deleting files#1163

Merged
Arnei merged 1 commit intoopencast:mainfrom
lkiesow:delete-phrasing
Mar 31, 2025
Merged

Improve phrasing of warning when deleting files#1163
Arnei merged 1 commit intoopencast:mainfrom
lkiesow:delete-phrasing

Conversation

@lkiesow
Copy link
Copy Markdown
Member

@lkiesow lkiesow commented Mar 18, 2025

The sentence “once deleted, [they] will be deleted […]” just sounds wrong.

The sentence “once deleted, [they] will be deleted […]” just sounds
wrong.
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1163/2025-03-18_23-39-08/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1163

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1163

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Copy Markdown
Contributor

@NadiaUoM NadiaUoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label is missing... otherwise changes are reflecting as expected.
PR_1163

@NadiaUoM
Copy link
Copy Markdown
Contributor

NadiaUoM commented Mar 19, 2025

One more question this warning notification are configured in different languages json files. But you did changes only in US so your changes are working only if select language English US. I know OC doesn't support some languages but as per my understanding the warning notification should be consistent across the languages. I mean this changes can be done to other languages which we are not using but still display the content in English e.g. Dansk, English UK. Just a thought.

@Arnei Arnei added the type:visual-clarity Improves UI readability label Mar 20, 2025
@Arnei
Copy link
Copy Markdown
Member

Arnei commented Mar 26, 2025

One more question this warning notification are configured in different languages json files. But you did changes only in US so your changes are working only if select language English US. I know OC doesn't support some languages but as per my understanding the warning notification should be consistent across the languages. I mean this changes can be done to other languages which we are not using but still display the content in English e.g. Dansk, English UK. Just a thought.

en_US is the "master language" so to speak. If there is not translation available for a given translation string, the translation from en_US will be displayed.

Translations are not done in pull requests, but through the crowdin web interface, see: https://github.com/opencast/opencast-admin-interface?tab=readme-ov-file#translating-the-admin-interface

@NadiaUoM
Copy link
Copy Markdown
Contributor

NadiaUoM commented Mar 26, 2025

One more question this warning notification are configured in different languages json files. But you did changes only in US so your changes are working only if select language English US. I know OC doesn't support some languages but as per my understanding the warning notification should be consistent across the languages. I mean this changes can be done to other languages which we are not using but still display the content in English e.g. Dansk, English UK. Just a thought.

en_US is the "master language" so to speak. If there is not translation available for a given translation string, the translation from en_US will be displayed.

Translations are not done in pull requests, but through the crowdin web interface, see: https://github.com/opencast/opencast-admin-interface?tab=readme-ov-file#translating-the-admin-interface

Ahhh that make sense now... Thanks for the explanation Arnei.... We are good to go with this PR... I just wanted to make sure.. :-)

@Arnei Arnei merged commit f66f82c into opencast:main Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:visual-clarity Improves UI readability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants