Skip to content

Sorting capture devices by last-updated-timestamp isn't possible#1240

Merged
gregorydlogan merged 2 commits intoopencast:mainfrom
wsmirnow:disable-location-sorting-by-last-updated
May 16, 2025
Merged

Sorting capture devices by last-updated-timestamp isn't possible#1240
gregorydlogan merged 2 commits intoopencast:mainfrom
wsmirnow:disable-location-sorting-by-last-updated

Conversation

@wsmirnow
Copy link
Copy Markdown
Contributor

Let's disable the sorting table by this column.

Fixes #1209

Let's disable the sorting table by this column.
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1240

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1240

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2025

This pull request is deployed at test.admin-interface.opencast.org/1240/2025-05-15_11-55-49/ .
It might take a few minutes for it to become available.

@Arnei Arnei added the type:bug Something isn't working label May 13, 2025
@stefanosgeo
Copy link
Copy Markdown
Contributor

I don't think this is a good idea. In some cases, sorting the CAs by their 'last updated' timestamp makes more sense—because although the status might show 'online', the CA could actually be offline, and the status hasn't been updated yet.

Screenshot_20250513_161623

@Arnei
Copy link
Copy Markdown
Member

Arnei commented May 14, 2025

I'm inclined to agree with Stefanos. We have other date columns that are sortable, I see no reason to make this one in particular unsortable.

@gregorydlogan
Copy link
Copy Markdown
Member

@wsmirnow see my comment on #1209: rest call is sorting on update, needs to be updated.

@wsmirnow
Copy link
Copy Markdown
Contributor Author

@wsmirnow see my comment on #1209: rest call is sorting on update, needs to be updated.

Thank you @gregorydlogan, I've updated this PR accordingly. The sorting by updated collumn is enabled again and fixed by using same naming as OC backend.

@wsmirnow
Copy link
Copy Markdown
Contributor Author

image

@stefanosgeo stefanosgeo self-requested a review May 15, 2025 12:08
@stefanosgeo
Copy link
Copy Markdown
Contributor

@wsmirnow I can review this...

@stefanosgeo
Copy link
Copy Markdown
Contributor

I proxied the PR with our dev cluster, but I’m unable to sort the CAs. Did I do something wrong?

2025-05-15.14-27.Display.OC.Studio.webm

@wsmirnow
Copy link
Copy Markdown
Contributor Author

I proxied the PR with our dev cluster, but I’m unable to sort the CAs. Did I do something wrong?

2025-05-15.14-27.Display.OC.Studio.webm

Please remove cookies and try again.

Copy link
Copy Markdown
Contributor

@stefanosgeo stefanosgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting per update column is now working, and code change looks good

@gregorydlogan gregorydlogan self-assigned this May 15, 2025
@gregorydlogan gregorydlogan merged commit 1fff072 into opencast:main May 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Locations: Sorting by 'Last updated' not possible although the option is available

4 participants