Skip to content

Changing themes of series fixed#1254

Merged
Arnei merged 3 commits intoopencast:mainfrom
wsmirnow:themes-cant-be-changed-for-series
May 16, 2025
Merged

Changing themes of series fixed#1254
Arnei merged 3 commits intoopencast:mainfrom
wsmirnow:themes-cant-be-changed-for-series

Conversation

@wsmirnow
Copy link
Copy Markdown
Contributor

In the series dialog the themes selection is fixed.

fixes #1205

In the series dialog the themes selection is fixed.

fixes opencast#1205
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1254

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1254

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2025

This pull request is deployed at test.admin-interface.opencast.org/1254/2025-05-16_07-20-19/ .
It might take a few minutes for it to become available.

@wsmirnow wsmirnow added the type:bug Something isn't working label May 14, 2025
@snoesberger snoesberger self-requested a review May 14, 2025 07:30
@Arnei Arnei self-requested a review May 14, 2025 08:59
Copy link
Copy Markdown
Contributor

@snoesberger snoesberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested the changes. I was able to change the theme of an existing series.

The code changes do also look appropriate to me.

Copy link
Copy Markdown
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and code looks generally good to me. I have some typescript considerations, tell me what you think about them.

Comment thread src/slices/seriesDetailsSlice.ts
Comment thread src/components/events/partials/ModalTabsAndPages/SeriesDetailsThemeTab.tsx Outdated
Comment thread src/slices/seriesDetailsSlice.ts Outdated
@wsmirnow wsmirnow force-pushed the themes-cant-be-changed-for-series branch from 57933e4 to 0f275b3 Compare May 15, 2025 14:28
@wsmirnow wsmirnow requested a review from Arnei May 15, 2025 14:31
@Arnei Arnei merged commit 6ac49a4 into opencast:main May 16, 2025
5 checks passed
mtneug added a commit to tales-media/fork-opencast-admin-interface that referenced this pull request Jun 1, 2025
* upstream/r/17.x: (191 commits)
  Revert "Merge branch 'seperate-user-and-non-user-roles' of Arnei/opencast-admin-interface into main"
  Automatically update translation keys
  Uncheck 'Select all' header cell on page change (opencast#1196)
  Automatically update translation keys
  Changing themes of series fixed (opencast#1254)
  Display only directly assigned roles in user modal (opencast#1251)
  Reactivated location table sorting by udated date
  Implement broadcast synchronization for logout events and user authentication (opencast#1274)
  make cancel buttons work for users/groups/access (opencast#1277)
  Different text for bottom set of roles in ACL view
  make sure override is there where needed
  make override optional
  Modernize the `Dockerfile`
  deselect all items in the table before sorting
  Minor eslint fixes
  Fix checkbox name for contact me field in RegistrationModal
  fix overlapping notifications + add title in upload notification
  minor fixes
  Add override button functionality to access policy components for series,
  Add two tabs indentation
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Themes can't be changed for series

3 participants