Enable lints#1312
Conversation
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1312/2025-06-18_09-00-27/ . |
|
@gregorydlogan You said something about switching tabs for spaces when rewriting history. Would this also qualify, because this is also automatically generated style changes? |
This comment was marked as resolved.
This comment was marked as resolved.
2a6edbd to
1bb168d
Compare
|
I probably can, but I'm not sure I should. While this is 'just' style changes, it changes what the functional content of the commit is. For example, a commit authored with a given style 2 years ago would now get current style applied to it. The only reason I'm planning on applying the whitespace changes are that they do not affect a given commit's buildability. |
|
I see, thanks for the explanation. |
This comment was marked as resolved.
This comment was marked as resolved.
1bb168d to
810cdb0
Compare
|
This pull request has conflicts ☹ |
810cdb0 to
6044949
Compare
We currently disable some of the lints that our chosen ESLint config has in it because, well, the code currently just doesn't follow that style. It should, though, and this is my first push towards making it so.
Starting with the simple rules, this PR has two commits:
Please don't be intimidated by the size of this diff. You literally only need to check
eslint.config.js. If you want to verify the rest, just run the above command on the first commit. I promise I didn't sneak in a backdoor. 😉Also this will probably cause a lot of conflicts with other PRs. I'm prepared to keep this updated if people want to wait for something major, given that it is trivial to update, but that also means that we shouldn't wait an eternity to merge it since other people can update their PRs equally trivially.