Skip to content

Enable lints#1312

Merged
Arnei merged 2 commits intoopencast:developfrom
JulianKniephoff:enable-lints
Jun 18, 2025
Merged

Enable lints#1312
Arnei merged 2 commits intoopencast:developfrom
JulianKniephoff:enable-lints

Conversation

@JulianKniephoff
Copy link
Copy Markdown
Member

We currently disable some of the lints that our chosen ESLint config has in it because, well, the code currently just doesn't follow that style. It should, though, and this is my first push towards making it so.

Starting with the simple rules, this PR has two commits:

  • The first just enables a few more rules
  • The second is literally what you get when you run the command in that commit's message, i.e.
    npx eslint . --fix
    

Please don't be intimidated by the size of this diff. You literally only need to check eslint.config.js. If you want to verify the rest, just run the above command on the first commit. I promise I didn't sneak in a backdoor. 😉

Also this will probably cause a lot of conflicts with other PRs. I'm prepared to keep this updated if people want to wait for something major, given that it is trivial to update, but that also means that we shouldn't wait an eternity to merge it since other people can update their PRs equally trivially.

@JulianKniephoff JulianKniephoff added the type:code-enhancement Internal improvements to the codebase label May 26, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1312

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1312

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2025

This pull request is deployed at test.admin-interface.opencast.org/1312/2025-06-18_09-00-27/ .
It might take a few minutes for it to become available.

@Arnei
Copy link
Copy Markdown
Member

Arnei commented Jun 4, 2025

@gregorydlogan You said something about switching tabs for spaces when rewriting history. Would this also qualify, because this is also automatically generated style changes?

@github-actions

This comment was marked as resolved.

@gregorydlogan
Copy link
Copy Markdown
Member

I probably can, but I'm not sure I should. While this is 'just' style changes, it changes what the functional content of the commit is.

For example, a commit authored with a given style 2 years ago would now get current style applied to it. The only reason I'm planning on applying the whitespace changes are that they do not affect a given commit's buildability.

@Arnei
Copy link
Copy Markdown
Member

Arnei commented Jun 10, 2025

I see, thanks for the explanation.

@github-actions

This comment was marked as resolved.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei merged commit 92c4d34 into opencast:develop Jun 18, 2025
5 checks passed
@JulianKniephoff JulianKniephoff deleted the enable-lints branch June 18, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:code-enhancement Internal improvements to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants