Correctly install optional native dependencies#1321
Merged
Arnei merged 1 commit intoopencast:developfrom Jun 12, 2025
Merged
Conversation
See opencast#1320 for a description of the problem. To fix it while causing minimal disruption to our `package-lock.json`, I did the following: - Run ```sh npm i -D @swc/core@1.11.24 rollup@4.40.2 esbuild@0.25.0 @parcel/watcher@2.5.0 ``` This installs (and saves to `package.json` under `devDependencies`) all the dependencies we have that have optional native transitive dependencies. The versions are the versions we currently have, so as to not update anything in the process. - Run ```sh git restore package.json npm i ``` We actually don't want these transitive deps as direct deps; we just wanted `npm` to update `package-lock.json`, which should have happened now. Hopefully fixes opencast#1320.
JulianKniephoff
added
type:dependencies
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/1321/2025-06-04_12-05-07/ . |
Arnei
approved these changes
Jun 10, 2025
Member
Arnei
left a comment
Arnei
left a comment
There was a problem hiding this comment.
Works on my Intel Dell. I have no way to test if this actually helps ARM Macs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1320 for a description of the problem.
To fix it while causing minimal disruption to our
package-lock.json, I did the following:Run
This installs (and saves to
package.jsonunderdevDependencies) all the dependencies we have that have optional native transitive dependencies. The versions are the versions we currently have, so as to not update anything in the process.Run
We actually don't want these transitive deps as direct deps; we just wanted
npmto updatepackage-lock.json, which should have happened now.Hopefully fixes #1320.