Skip to content

Remove unnecessary state#1327

Merged
Arnei merged 1 commit intoopencast:developfrom
JulianKniephoff:unnecessary-state
Jun 12, 2025
Merged

Remove unnecessary state#1327
Arnei merged 1 commit intoopencast:developfrom
JulianKniephoff:unnecessary-state

Conversation

@JulianKniephoff
Copy link
Copy Markdown
Member

When we never change the state, as indicated by not even bothering to grab the setter here, this is pure overhead.

When we never change the state, as indicated by not even bothering
to grab the setter here, this is pure overhead.
@JulianKniephoff JulianKniephoff added the type:code-enhancement Internal improvements to the codebase label Jun 10, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1327

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1327

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1327/2025-06-10_13-25-47/ .
It might take a few minutes for it to become available.

@Arnei Arnei merged commit 4d3457b into opencast:develop Jun 12, 2025
7 checks passed
@JulianKniephoff JulianKniephoff deleted the unnecessary-state branch June 16, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:code-enhancement Internal improvements to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants