Disable tooltips on tables due to performance issues#1433
Merged
gregorydlogan merged 1 commit intoopencast:r/17.xfrom Sep 25, 2025
Merged
Disable tooltips on tables due to performance issues#1433gregorydlogan merged 1 commit intoopencast:r/17.xfrom
gregorydlogan merged 1 commit intoopencast:r/17.xfrom
Conversation
This commit disables tooltips for all table cells. For example, when moving the mouse over the red X in the events table, there will no longer be a tooltip showing. This is done to imporve performance. It appears that the mui tooltip component is not performant when used in large quantities. According to this comment on github it is not supposed to be: mui/material-ui#27057 (comment) I locally tested performance by profiling the rendering of the rows of the series table. The table had 1000 entries which necessitated 4000 tooltip components. Rendering the table with tooltips took about 3,7 seconds. Rendering the table without tooltips took about 1,2 seconds. I think this is way too much time for tooltips. The goal of this commit is to be a quick fix for quick gains. A more proper long term solution would let us keep the tooltips, by for example working around the issue somehow or replacing mui tooltips with a different library.
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit disables tooltips for all table cells. For example, when moving the mouse over the red X in the events table, there will no longer be a tooltip showing. This is done to improve performance.
It appears that the mui tooltip component is not performant when used in large quantities. According to this comment on github it is not supposed to be:
mui/material-ui#27057 (comment)
I locally tested performance by profiling the rendering of the rows of the series table. The table had 1000 entries which necessitated 4000 tooltip components. Rendering the table with tooltips took about 3,7 seconds. Rendering the table without tooltips took about 1,2 seconds. I think this is way too much time for tooltips.
The goal of this commit is to be a quick fix for quick gains. A more proper long term solution would let us keep the tooltips, by for example working around the issue somehow or replacing mui tooltips with a different library.
How to test this
Have an Opencast backend that provides 1000 events or series to the admin interface. For series, you can currently also use develop.opencast.org as your Opencast backend. Then check how long the respective table takes to load with and without this PR. The difference should be noticable even without any time measurements.