Skip to content

Respect publication channels listprovider more#738

Merged
Arnei merged 9 commits intoopencast:mainfrom
Arnei:publication-channels-listprovider
Jan 31, 2025
Merged

Respect publication channels listprovider more#738
Arnei merged 9 commits intoopencast:mainfrom
Arnei:publication-channels-listprovider

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Jun 25, 2024

While we were already getting information on publications from the respective listprovider for the event details, we were not putting all of it to use, for example ordering. Also, the event table did not have access to this information at all. This should fix that.

Helps with #409.

Screenshots, as the effects are rather unnoticeable without making changes to the listprovider.
Bildschirmfoto vom 2024-06-25 12-29-25
Bildschirmfoto vom 2024-06-25 12-29-41

This PR over in the main repository may also be of interest: opencast/opencast#5956

While we were already getting information on
publications from the respective listprovider for
the event details, we were not putting all of it to
use, for example ordering. Also, the event table
did not have access to this information at all.
This should fix that.
@Arnei Arnei added the type:bug Something isn't working label Jun 25, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-738

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-738

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 25, 2024

This pull request is deployed at test.admin-interface.opencast.org/738/2025-01-27_11-18-28/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei force-pushed the publication-channels-listprovider branch from ef58a81 to 1ddd1fa Compare July 1, 2024 07:32
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@snoesberger
Copy link
Copy Markdown
Contributor

I have tested this PR on our side with an Annotation Tool publication. Now the name is displayed correctly in the publications (before it was just named "Custom"):
grafik

@gregorydlogan
Copy link
Copy Markdown
Member

@Arnei build correctly fails due to tab character ;)

Copy link
Copy Markdown
Contributor

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable. I haven't done any testing because I don't know my way around the listprovider.
But since Sascha has done so, I think this should be fine to merge.

@Arnei Arnei merged commit fe113d7 into opencast:main Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants