Autofill presenter name with the info from /me.json #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkiesow
previously requested changes
May 12, 2023
Member
lkiesow
left a comment
lkiesow
left a comment
There was a problem hiding this comment.
If Opencast is unreachable, Studio shows an error. Once the connection can be established, the error disappears and the event can be uploaded. This code seems to cause a stack trace and seems to be unable to recover, however:
error when getting info/me Error: network error when accessing 'https://develop.opencast.org/info/me.json': TypeError: NetworkError when attempting to fetch resource.
q https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
Z https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
request https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
jsonRequest https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
getInfoMe https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
updateUser https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
refreshConnection https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
e https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/823.1e6ee22f.chunk.js:1
setTimeout handler*7448/Ae/< https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/823.1e6ee22f.chunk.js:1
nl https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
Su https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
ku https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
S https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
A https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
6813 https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
__webpack_require__ https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
5296 https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
__webpack_require__ https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
4463 https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
__webpack_require__ https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
4164 https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
__webpack_require__ https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
<anonymous> https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
<anonymous> https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
<anonymous> https://test.studio.opencast.org/2023-05-11_08-04-44-pr1037-4945454464/static/js/main.ce2c9eee.js:2
main.ce2c9eee.js:2:7963
This also seems to cause studio to load /info/me.json over and over again, as fast as it can at least when the user does not actually have a name. Deploying this could therefor actually lead to an unwanted DOS attack:
studio-auto-fill-name.mp4
At least the latter error should be addressed
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
status:conflicts
Contributor
Author
|
Studio should not load 'info/me.json' over and over again.
This should (hopefully) also been fixed. Not sure how to test it. |
LukasKalbertodt
requested changes
Sep 14, 2023
This patch adds a config option to specify a preference order of potential sources to autofill the presenter field from. Leaving it empty is equivalent to the current behavior. The only valid value right now is `"opencast"`, which gets the value from `/info/me.json`. The way the feature is built, it should be easy to extend in the future, though. If there is a name stored in `localStorage` already, this currently takes precedence over (any of) the suggested value(s). Co-authored-by: naweidner <weidner@elan-ev.de>
JulianKniephoff
dismissed
lkiesow’s stale review
Problems have been addressed
Member
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
Thanks for trying to get this PR done! Some comments, but just minor things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the presenter field is empty (and no value in local storage) the users name from info/me.json is used.