Fix public path once again #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully for good this time. Now the normalization (always ends with "/" is performed at the earliest possible moment). I tested with the env var not set, set to "/" and set to "/build".
owi92
approved these changes
Dec 5, 2023
Contributor
owi92
left a comment
owi92
left a comment
There was a problem hiding this comment.
Sorry this took so long but I finally got around to reviewing/testing this. Code looks good to me and I can confirm that both builds are working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully for good this time. Now the normalization (always ends with "/" is performed at the earliest possible moment). I tested with the env var not set, set to "/" and set to "/build".
Fixes #1151