chore: improve build and test pipeline and the release ochestrator#529
Merged
Conversation
mevan-karu
requested review from
kaviththiranga,
sameerajayasoma and
stefinie123
as code owners
📝 WalkthroughWalkthroughThe PR updates two GitHub Actions workflows. Build-and-test adds pull-request-aware concurrency grouping and a pre-build check for commit images in GHCR to skip redundant builds. Release-orchestrator refactors from a single job into separate ChangesCI/CD Workflow Improvements
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Mevan <mevan.karu@gmail.com>
mevan-karu
force-pushed
the
build_test_fix_1
branch
from
514c64f to
a367001
Compare
mevan-karu
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.github/workflows/build-and-test.yml (1)
194-204: ⚡ Quick winReuse the SHA from the tag step to avoid duplication.
The SHA is calculated twice—once in the "Set image tag" step (line 186) and again here (line 197). This duplication violates DRY and could theoretically lead to inconsistency if the git state changes between steps.
♻️ Proposed fix to reuse the SHA output
- name: Check if image already exists id: check-image run: | - SHA=$(git rev-parse --short=8 HEAD) + SHA="${{ steps.tag.outputs.GIT_SHA_SHORT }}" if docker buildx imagetools inspect "${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${SHA}" >/dev/null 2>&1; then echo "Image ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${SHA} already exists. Skipping build." echo "skip=true" >> $GITHUB_OUTPUT else echo "Image not found. Proceeding with build." echo "skip=false" >> $GITHUB_OUTPUT fi🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/build-and-test.yml around lines 194 - 204, The "Check if image already exists" step (id: check-image) recalculates the git SHA instead of reusing the SHA produced by the earlier "Set image tag" step; update the check-image step to reference the SHA output from the set-image-tag step (e.g. ${{ steps.set-image-tag.outputs.sha }}) when forming the image tag (instead of running git rev-parse again) so the build uses the single canonical SHA output and avoid duplication; ensure the referenced step id matches the actual id of the "Set image tag" step and keep using ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ steps.set-image-tag.outputs.sha }} in the docker imagetools inspect and the messages..github/workflows/release-orchestrator.yml (1)
217-217: 💤 Low valueOptional: reduce
fetch-depthfor the branch and tag jobs.Both
branchandtagjobs only need the resolved SHA to create a local branch / annotated tag and push it — full history isn't required.fetch-depth: 1(the default) should suffice and avoids cloning the entire history on every release run. The same applies to thetagjob at line 257. Thevalidatejob still needsfetch-depth: 0forgit ls-remote/git rev-parsecorrectness.♻️ Proposed diff for both jobs
- name: Checkout uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: token: ${{ steps.app-token.outputs.token }} ref: ${{ needs.validate.outputs.checkout-sha }} - fetch-depth: 0 + fetch-depth: 1And in the
tagjob:- name: Checkout uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: token: ${{ steps.app-token.outputs.token }} ref: ${{ needs.validate.outputs.target-commit }} - fetch-depth: 0 + fetch-depth: 1🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release-orchestrator.yml at line 217, Update the checkout steps in the branch and tag jobs to use a shallower clone by changing fetch-depth from 0 to 1 (i.e., set fetch-depth: 1 on the actions/checkout step in the jobs named "branch" and "tag"); leave the validate job's fetch-depth at 0 so git ls-remote / git rev-parse behavior is preserved. Ensure both job definitions explicitly include the updated fetch-depth under the checkout step so only the needed commit SHA is fetched.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/build-and-test.yml:
- Around line 194-204: The "Check if image already exists" step (id:
check-image) recalculates the git SHA instead of reusing the SHA produced by the
earlier "Set image tag" step; update the check-image step to reference the SHA
output from the set-image-tag step (e.g. ${{ steps.set-image-tag.outputs.sha }})
when forming the image tag (instead of running git rev-parse again) so the build
uses the single canonical SHA output and avoid duplication; ensure the
referenced step id matches the actual id of the "Set image tag" step and keep
using ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{
steps.set-image-tag.outputs.sha }} in the docker imagetools inspect and the
messages.
In @.github/workflows/release-orchestrator.yml:
- Line 217: Update the checkout steps in the branch and tag jobs to use a
shallower clone by changing fetch-depth from 0 to 1 (i.e., set fetch-depth: 1 on
the actions/checkout step in the jobs named "branch" and "tag"); leave the
validate job's fetch-depth at 0 so git ls-remote / git rev-parse behavior is
preserved. Ensure both job definitions explicitly include the updated
fetch-depth under the checkout step so only the needed commit SHA is fetched.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a1fee32e-617e-4eb5-8b29-8cbebb0695b2
📒 Files selected for processing (2)
.github/workflows/build-and-test.yml.github/workflows/release-orchestrator.yml
kaviththiranga
approved these changes
May 13, 2026
LakshanSS
reviewed
May 13, 2026
Comment on lines
+196
to
+204
| run: | | ||
| SHA=$(git rev-parse --short=8 HEAD) | ||
| if docker buildx imagetools inspect "${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${SHA}" >/dev/null 2>&1; then | ||
| echo "Image ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${SHA} already exists. Skipping build." | ||
| echo "skip=true" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "Image not found. Proceeding with build." | ||
| echo "skip=false" >> $GITHUB_OUTPUT | ||
| fi |
Contributor
There was a problem hiding this comment.
Suggested improvement:
run: |
SHA=$(git rev-parse --short=8 HEAD)
IMAGE="${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${SHA}"
echo "Checking if image exists: ${IMAGE}"
if docker buildx imagetools inspect "${IMAGE}" 2>&1; then
echo "Image ${IMAGE} already exists. Skipping build."
echo "skip=true" >> $GITHUB_OUTPUT
else
echo "Image not found. Proceeding with build."
echo "skip=false" >> $GITHUB_OUTPUT
fi
LakshanSS
approved these changes
May 13, 2026
Contributor
LakshanSS
left a comment
LakshanSS
left a comment
There was a problem hiding this comment.
Approved with a minor suggestion
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$subject
Related to - openchoreo/openchoreo#3341
Summary by CodeRabbit