fix: trigger metrics fetch on initial observability page load

[rashadism]

Summary

Metrics page sometimes loads empty until the user clicks Refresh or changes a filter. The useEffect used a previousFiltersRef initialized from live first-render filter values, so when the page mounted with env already resolved (URL carries ?env=..., or environments resolve from cache) the first diff was a no-op and the fetch was skipped.

useMetrics already guards on env + timeRange internally, so the manual diff was redundant. Drop the ref; let the effect's dep array (env, timeRange, canViewMetricsForEnv, fetchMetrics) trigger the fetch.

Side effect: changing the custom date range now refetches automatically instead of needing Refresh.

HTTPMetricsSection is untouched — separate component, separate ref, cilium gate intact.

Test plan

• CPU / memory cards populate on initial mount with ?env=... in the URL.
• Initial mount with no URL env (auto-select path).
• Env / time-range / custom date changes all refetch.
• HTTP metrics cards still hide when cilium disabled and fetch independently when enabled.
• Per-env permission denial still hides cards and skips fetch.

[coderabbitai]

📝 Walkthrough

Walkthrough

ObservabilityMetricsPage.tsx removes useRef-based filter-change tracking and replaces it with a direct useEffect that fetches metrics when environment, time range, and view permissions are available. The React import is updated to remove useRef.

Changes

Metrics Fetch Effect Refactor

Layer / File(s)	Summary
Metrics fetch effect refactor plugins/openchoreo-observability/src/components/Metrics/ObservabilityMetricsPage.tsx	React import drops useRef. The metrics-fetch useEffect is rewritten to trigger directly on environment, time range, and permission conditions instead of tracking previous filters with a ref and comparing JSON stringified values; dependency list is simplified.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A ref once tracked filters with care,
But now the effect takes the air!
Simpler deps, cleaner flow,
Watch those metrics brightly glow. 📊

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is missing several required sections from the template, including Goals, Approach, User stories, Release note, Documentation, Training, Certification, Marketing, Automation tests, Security checks, Samples, Related PRs, Migrations, Test environment, and Learning.	Complete the PR description by adding all missing sections from the template. At minimum, provide Goals, Approach, User stories, Release note, Documentation, and Automation tests sections with relevant information.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: trigger metrics fetch on initial observability page load' clearly and concisely describes the main bug fix: ensuring metrics are fetched when the observability page initially loads.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!