Skip to content

chore: bump codex and claude ACP adapter ranges#163

Merged
dutifulbob merged 2 commits intoopenclaw:mainfrom
moritzketzer:fix/bump-claude-adapter-range
Mar 28, 2026
Merged

chore: bump codex and claude ACP adapter ranges#163
dutifulbob merged 2 commits intoopenclaw:mainfrom
moritzketzer:fix/bump-claude-adapter-range

Conversation

@moritzketzer
Copy link
Copy Markdown
Contributor

@moritzketzer moritzketzer commented Mar 19, 2026

Problem

The built-in ACP adapter ranges for Codex and Claude were behind the latest npm releases.

As of March 28, 2026, npm reports:

  • @zed-industries/codex-acp: 0.10.0
  • @zed-industries/claude-agent-acp: 0.23.1

Fix

Update the built-in adapter package ranges in src/agent-registry.ts:

  • codex: ^0.9.5 -> ^0.10.0
  • claude: ^0.21.0 -> ^0.23.1

Verification

  • npm view @zed-industries/codex-acp dist-tags --json
  • npm view @zed-industries/claude-agent-acp dist-tags --json
  • pnpm run build
  • pnpm exec tsx --test test/agent-registry.test.ts
  • pnpm exec tsx --test test/version.test.ts

Notes

pnpm run build:test is currently failing on this branch due to an existing ACP SDK typing mismatch unrelated to this adapter-range change:

  • src/client.ts: missing KillTerminalRequest / KillTerminalResponse exports from @agentclientprotocol/sdk
  • src/terminal.ts: missing KillTerminalRequest / KillTerminalResponse exports from @agentclientprotocol/sdk

claude-agent-acp 0.21.0 (SDK 0.2.71) has a bug where `session/new`
fails with "Query closed before response received" — the inner Claude
Code subprocess closes during initialization. This was fixed upstream
in 0.22.0 (SDK 0.2.76), but the ^0.21.0 semver range prevents
resolving to 0.22.x.

Verified: adapter 0.22.2 creates sessions successfully, full
round-trip prompt/response works. All 253 tests pass.
Copilot AI review requested due to automatic review settings March 19, 2026 11:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the default semver range used for the built-in Claude ACP adapter command to pick up an upstream fix that prevents session/new failures (“Query closed before response received”).

Changes:

  • Bump @zed-industries/claude-agent-acp adapter range from ^0.21.0 to ^0.22.0 in the built-in agent registry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@dutifulbob
Copy link
Copy Markdown
Collaborator

Triage result

Human attention: ⚠️ Required
Recommendation: 🏁 escalate to a human
Human decision needed: decide whether the PR's stated manual verification is sufficient for landing, or provide a concrete repro/verification path for the Claude session/new failure first

Quick read

This PR is a one-line built-in adapter bump in src/agent-registry.ts, changing Claude from ^0.21.0 to ^0.22.0 so acpx defaults to an upstream adapter version that reportedly fixes session/new failures.

The change is right-shaped for the reported problem, and the initial conflict gate against origin/main was clean. The blocker is validation: this flow classified the PR as a bug fix, but no targeted local repro or proof-of-fix command could be derived here, so the fix is still not proven in-flow.

Intent

Update acpx's built-in Claude adapter version range so new Claude sessions use a fixed upstream adapter and work by default.

Why

The underlying issue is that acpx currently resolves the built-in Claude command to ^0.21.0, which pulls a buggy claude-agent-acp release that can close during session initialization and cause session/new to fail with Query closed before response received.

Codex review

No Codex review findings were produced on this handoff path.

The solution assessment so far is that the PR is likely correct because it changes the exact built-in version range implicated by the bug and does not broaden scope beyond that default registry mapping.

CI/CD

Initial conflict status: clean against origin/main.

CI/CD status was not evaluated in this handoff step, and no final conflict gate result is available yet.

Recommendation

A human should decide whether the author's stated manual verification is enough evidence for this bug-fix PR, or provide a concrete reproduction and verification path before continuing.

If a maintainer is satisfied that the upstream adapter fix is the real root cause and the range bump is the intended product behavior, this can continue after that human judgment.

@dutifulbob dutifulbob changed the title fix: bump claude adapter range to ^0.22.0 chore: bump codex and claude ACP adapter ranges Mar 28, 2026
@dutifulbob dutifulbob merged commit d4820f4 into openclaw:main Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants