fix: enable shell for terminal spawn on Windows#173
Open
Bortlesboat wants to merge 1 commit intoopenclaw:mainfrom
Open
fix: enable shell for terminal spawn on Windows#173Bortlesboat wants to merge 1 commit intoopenclaw:mainfrom
Bortlesboat wants to merge 1 commit intoopenclaw:mainfrom
Conversation
On Windows, Node.js child_process.spawn() without shell:true does not use cmd.exe to resolve commands from PATH. This causes every terminal command to fail with ENOENT. Linux/macOS kernels handle PATH resolution during execve(), so only Windows needs the shell flag. Closes openclaw#169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell: process.platform === "win32"tobuildTerminalSpawnOptions()so terminal commands resolve from PATH on Windowschild_process.spawn()withoutshell: truedoesn't usecmd.exefor PATH resolution, causing every terminal command to fail withENOENTexecve(), soshellis only enabled on WindowsTest plan
spawn-options.test.tsverifyingshellis always a booleanoxlint,oxfmt, andtsc --noEmitcleanCloses #169