Skip to content

fix: validate maintenance PRs via standard repo checks#187

Merged
osolmaz merged 3 commits intomainfrom
codex/pr-triage-maintenance-validation
Mar 28, 2026
Merged

fix: validate maintenance PRs via standard repo checks#187
osolmaz merged 3 commits intomainfrom
codex/pr-triage-maintenance-validation

Conversation

@osolmaz
Copy link
Copy Markdown
Member

@osolmaz osolmaz commented Mar 28, 2026

Summary

  • keep dependency/tooling/docs/lockfile maintenance PRs on the existing feature path
  • let the feature-validation step treat normal repo review and CI as meaningful validation for that maintenance scope
  • add a regression test so this stays in the existing graph shape without a new flow node

Validation

  • pnpm run build:test && node --test dist-test/test/pr-triage-example.test.js
  • pnpm exec tsx -e "import('./examples/flows/pr-triage/pr-triage.flow.ts').then(() => console.log('ok'))"
  • pnpm run check:docs
  • pnpm run check

Live check

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ae645cb5d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1345 to +1346
rawLine.startsWith("@@")
) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset section tracking at each diff hunk boundary

The parser keeps currentTopLevelKey across @@ hunk boundaries, so a patch that first edits devDependencies and then edits an unrelated top-level scalar in a later hunk can still be treated as devDependencies-only. In that case packageJsonPatchIsMaintenanceOnly returns true, and supportsStandardChecksValidation can route a non-maintenance PR to standard_checks_sufficient instead of escalation.

Useful? React with 👍 / 👎.

Comment on lines +1374 to +1375
const allowedRootChange = /^ {2}"packageManager": /.test(line) || /^ {2}"pnpm": \{$/.test(line);
if (allowedRootChange) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Accept full pnpm block edits as maintenance changes

The maintenance allowlist only matches the opening line "pnpm": {, but real pnpm config updates also change nested lines and closing braces, which immediately hit return false. That means pnpm-only tooling maintenance PRs still fail this check and get escalated as unvalidated, despite the new feature-path behavior intended for maintenance scope.

Useful? React with 👍 / 👎.

@osolmaz osolmaz self-assigned this Mar 28, 2026
@osolmaz osolmaz merged commit 2475a3f into main Mar 28, 2026
8 checks passed
@osolmaz osolmaz deleted the codex/pr-triage-maintenance-validation branch March 28, 2026 10:07
@osolmaz
Copy link
Copy Markdown
Member Author

osolmaz commented Mar 28, 2026

Landed via temp rebase onto main.

  • Gate: validation completed for this repo's change scope
  • Land commit: 47ce894
  • Merge commit: 2475a3f

Thanks @osolmaz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant