flow: broaden pr-triage refactor judgment#190
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fec441d6e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "Do not only think about refactor depth. Also ask whether the PR includes any small extra behavior, missing follow-through, or unnecessary complexity that should be cleaned up before review and CI.", | ||
| "Use `none` only if nothing should be added, removed, simplified, or reshaped before the PR continues.", | ||
| "Use `superficial` if the main direction is fine but there is still some minor thing that should be added, removed, simplified, or locally refactored first.", |
There was a problem hiding this comment.
Align superficial criteria with execution prompt
promptJudgeRefactor now defines superficial as including minor additions/removals and missing follow-through, but the downstream promptDoSuperficialRefactor step still tells the agent to keep changes “maintainability-focused.” This creates a mismatch where the flow can route a PR to do_superficial_refactor for a small functional gap, then discourage making that required functional change, allowing the PR to proceed to review/CI without the intended follow-through being completed.
Useful? React with 👍 / 👎.
9643710 to
ebdc68d
Compare
Summary
judge_refactorso it asks whether anything should be added, removed, simplified, or refactored before a PR continuesnone/superficial/fundamentalcategories and the same flow graph shapeValidation
pnpm run build:test && node --test dist-test/test/pr-triage-example.test.jspnpm run checkpnpm run check:docs