Skip to content

flow: broaden pr-triage refactor judgment#190

Merged
osolmaz merged 8 commits intomainfrom
codex/pr-triage-refactor-judgment-wording
Mar 29, 2026
Merged

flow: broaden pr-triage refactor judgment#190
osolmaz merged 8 commits intomainfrom
codex/pr-triage-refactor-judgment-wording

Conversation

@osolmaz
Copy link
Copy Markdown
Member

@osolmaz osolmaz commented Mar 28, 2026

Summary

  • broaden judge_refactor so it asks whether anything should be added, removed, simplified, or refactored before a PR continues
  • keep the existing none / superficial / fundamental categories and the same flow graph shape
  • update the PR-triage README and add a regression test for the new wording

Validation

  • pnpm run build:test && node --test dist-test/test/pr-triage-example.test.js
  • pnpm run check
  • pnpm run check:docs

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fec441d6e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +925 to +927
"Do not only think about refactor depth. Also ask whether the PR includes any small extra behavior, missing follow-through, or unnecessary complexity that should be cleaned up before review and CI.",
"Use `none` only if nothing should be added, removed, simplified, or reshaped before the PR continues.",
"Use `superficial` if the main direction is fine but there is still some minor thing that should be added, removed, simplified, or locally refactored first.",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align superficial criteria with execution prompt

promptJudgeRefactor now defines superficial as including minor additions/removals and missing follow-through, but the downstream promptDoSuperficialRefactor step still tells the agent to keep changes “maintainability-focused.” This creates a mismatch where the flow can route a PR to do_superficial_refactor for a small functional gap, then discourage making that required functional change, allowing the PR to proceed to review/CI without the intended follow-through being completed.

Useful? React with 👍 / 👎.

@osolmaz osolmaz self-assigned this Mar 29, 2026
@osolmaz osolmaz force-pushed the codex/pr-triage-refactor-judgment-wording branch from 9643710 to ebdc68d Compare March 29, 2026 09:06
@osolmaz osolmaz merged commit aff31b3 into main Mar 29, 2026
8 checks passed
@osolmaz osolmaz deleted the codex/pr-triage-refactor-judgment-wording branch March 29, 2026 09:07
@osolmaz
Copy link
Copy Markdown
Member Author

osolmaz commented Mar 29, 2026

Landed via temp rebase onto main.\n\n- Gate: focused flow regression and docs validation passed locally; full local still hits the same repo-local coverage baseline failure that shows in this environment\n- Land commit: ebdc68d\n- Merge commit: aff31b3\n\nThanks @osolmaz!

@osolmaz
Copy link
Copy Markdown
Member Author

osolmaz commented Mar 29, 2026

Landed via temp rebase onto main.

  • Gate: focused flow regression and docs validation passed locally; full local pnpm run check still hits the same repo-local coverage baseline failure that main shows in this environment
  • Land commit: ebdc68d
  • Merge commit: aff31b3

Thanks @osolmaz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant