Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Validation summary:
Validation run on current head
CI:
There are no open review threads on the PR at this head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Prompt execution was still keyed too tightly to the prompt RPC result. That left a gap where a reply could already exist in session state while the RPC path still timed out. The first turn on a freshly created persistent session could also fail because the runtime threw away the live client and immediately tried to resume the session.
Impact
This makes prompt handling more consistent across the CLI runtime and the embedded runtime API, and it closes the late-reply timeout case that was breaking downstream flows.
Validation
pnpm -s typecheck:tscpnpm -s buildpnpm -s build:test && node --test dist-test/test/runtime-manager.test.js --test-name-pattern 'streams runtime events and saves updated status|accepts a session reply even when the prompt RPC times out'