fix(win32): resolve Claude Code executable path for ACP spawn#289
Merged
Conversation
On Windows, when CLAUDE_CODE_EXECUTABLE is not already set, resolve the claude.exe on PATH and inject it into the spawn env before starting the ACP child process. This avoids path-resolution failures in environments where the shell's PATH lookup does not work the same way as Node's spawn. Exports readWindowsEnvValue and resolveWindowsCommand so they can be reused from agent-command.ts, and adds resolveClaudeCodeExecutable with full test coverage.
Contributor
|
Maintainer triage: patch applies cleanly and CI is green. The remaining blocker is repo policy: this is a user-visible Windows/Claude ACP spawn fix, so please add a concise CHANGELOG.md entry under Unreleased / Fixes before merge. |
Contributor
|
Landed.\n\n- Gate: pnpm run check; GitHub CI green on "3637bce325a32bcf083626a3e9d4ee6534b19594"\n- Merge commit: 436fd4f\n\nThanks @MikeChongCan! |
steipete
pushed a commit
that referenced
this pull request
May 5, 2026
Send session/close from AcpClient.closeSession instead of the experimental nes/close method.\n\nGate: pnpm run check locally on PR branch; rebased onto main after #289.\n\nThanks @hexsprite.
5 tasks
steipete
pushed a commit
that referenced
this pull request
May 5, 2026
…tion Recognize Windows .cmd/.bat ACP agent wrappers when translating WSL cwd, including non-C drive installs.\n\nGate: pnpm run check locally on PR branch; rebased onto main after #289 and #291.\n\nThanks @solomonneas.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, when CLAUDE_CODE_EXECUTABLE is not already set, resolve claude.exe on PATH and inject it into the spawn environment before starting the ACP child process. This avoids path-resolution failures in environments where the shell's PATH lookup does not work the same way as Node's spawn.
Changes