fix: support ACP audio prompt content#335
Merged
Merged
Conversation
27e89d0 to
e43a4c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session/promptwhen the agent does not advertise the matchingpromptCapabilitiesaudio/*attachments into ACP audio content blocksWhy
ACP requires clients to restrict prompt content according to
agentCapabilities.promptCapabilities.acpxpreviously accepted and sent image/resource prompt blocks without checking the negotiated capability set, and it did not accept ACP audio content blocks even though ACP defines them.Validation
pnpm run format:checkpnpm run typecheckpnpm run lintpnpm run buildpnpm run viewer:typecheckpnpm run viewer:buildpnpm run build:testnode --test dist-test/test/prompt-content.test.js dist-test/test/client.test.js dist-test/test/runtime-manager.test.js dist-test/test/session-conversation-model.test.js dist-test/test/session-persistence.test.js dist-test/test/persisted-key-policy.test.js dist-test/test/queue-messages.test.js dist-test/test/runtime-events.test.jsnode --test --test-name-pattern "structured ACP prompt blocks" dist-test/test/cli.test.jsKnown validation note
pnpm run test:coveragecurrently stops on one unrelated existing CLI routing test onorigin/main:CLI resolves unknown raw agent commands after newer global flags. In that run, 704 tests passed and that one test failed before the coverage phase executed.