Fixes Monaco editor instantiation in Light mode#13
Closed
bradleypriest wants to merge 1 commit intoopenclaw:mainfrom
Closed
Fixes Monaco editor instantiation in Light mode#13bradleypriest wants to merge 1 commit intoopenclaw:mainfrom
bradleypriest wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Currently the skills page is crashing when clicking compare (in light mode only). `Uncaught Error: Illegal value for token color: #fff` The Monaco Editor expects full hex codes in it's theming, and whilst it is being set as "#ffffff" in the styles.css, some part of the build process (likely the Vite CSS minifier) is converting it to "#fff" in the live site. This is a pretty hacky fix, but seems to solve the problem. Fixes openclaw#9
Contributor
|
@bradleypriest is attempting to deploy a commit to the Amantus Machina Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thanks! We already fixed this in #4 (normalize hex colors in SkillDiffCard). This PR only normalizes surface, so I'll close as duplicate. |
Author
|
Hey @steipete that fixed a similar problem, but this is I guess a spot where that Pr missed. |
Contributor
|
Looking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the skills page is crashing when clicking compare (in light mode only).
Uncaught Error: Illegal value for token color: #fffThe Monaco Editor expects full hex codes in it's theming, and whilst it is being set as "#ffffff" in the styles.css, some part of the build process (likely the Vite CSS minifier) is converting it to "#fff" in the live site.
This is a pretty hacky fix, but seems to solve the problem.
Fixes #9