Streamline local Ollama embeddings#2012
Conversation
|
@fuller-stack-dev is attempting to deploy a commit to the Amantus Machina Team on Vercel. A member of the Team first needs to authorize it. |
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: not applicable. this is a feature PR, not a bug report. Source inspection shows current main lacks the requested Ollama provider/setup/docs, while PR head adds the new behavior and tests. Real behavior proof Next step before merge Security Review detailsBest possible solution: Land a rebased version only after maintainers accept the local Ollama default and the contributor adds redacted proof from a real local Ollama/Convex setup, keeping provider logic centralized with matching docs and tests. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a feature PR, not a bug report. Source inspection shows current main lacks the requested Ollama provider/setup/docs, while PR head adds the new behavior and tests. Is this the best way to solve the issue? Unclear until maintainer acceptance and proof: centralizing provider selection in convex/lib/embeddings.ts is a maintainable direction, but the automatic anonymous Convex default and local setup behavior should be approved and demonstrated before merge. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 5b63d5df6071. |
|
Addressed the review feedback by adding the required New commit: caec0a9 ( Verified: bun run format:check -- CHANGELOG.md |
caec0a9 to
2da46c2
Compare
|
Updated the changelog entry to match the existing attribution style: (#2012) (thanks @fuller-stack-dev)Amended commit: 2da46c2 ( Verified: bun run format:check -- CHANGELOG.md |
|
Is that a goal? What are you doing? Setting up a local ClawHub? I don't really wanna support that. |
Summary
OPENAI_API_KEYis absentbun run setup:local-embeddingsto pull/configure the default local embedding modelTests
bunx vitest run convex/lib/embeddings.test.tsbunx tsc --noEmitbun run lintbun run testnode scripts/setup-local-embeddings.mjs --helpbun run format:check -- convex/lib/embeddings.ts convex/lib/embeddings.test.ts convex/devSeed.ts convex/devSeedExtra.ts convex/lib/skillPublish.ts convex/lib/soulPublish.ts scripts/setup-local-embeddings.mjs package.json README.md CONTRIBUTING.md docs/README.md docs/quickstart.md docs/troubleshooting.md docs/local-embeddings.mdNote: full
bun run format:checkwas also attempted locally, but failed only on pre-existing unstaged.agents/...worktree files that are not included in this PR.