fix: make review feature locks atomic#13
Merged
steipete merged 3 commits intoMay 16, 2026
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c43fa7a7ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
rohitjavvadi
force-pushed
the
fix/atomic-review-feature-locks
branch
from
c43fa7a to
06b6950
Compare
…ture-locks # Conflicts: # CHANGELOG.md # src/workflow.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix cross-process review locking so overlapping
clawpatch reviewruns cannot claim and review the same feature at the same time.Problem
reviewCommandselects features once at the start of a run, then each worker attempts to lock a feature from that in-memory snapshot. Two separate review processes can both read a feature whilelockis stillnull, then both persist a claimed copy and continue into provider review.That can duplicate provider calls and leave feature state dependent on whichever process writes last. It also conflicts with the documented behavior that overlapping runs should not claim the same feature.
Changes
.clawpatch/locks/<featureId>.jsonwith exclusive file creation.clean-locksto remove lock files as well as embedded feature locks.randomUUID()to avoid same-process timestamp collisions.Validation
corepack pnpm typecheckcorepack pnpm lintcorepack pnpm format:checkcorepack pnpm testcorepack pnpm buildI also ran a disposable local repro with two concurrent
reviewCommandcalls against the same temp project. After this change, one review succeeds, the other fails withlock-conflict, and no lock files are left behind.