Skip to content

fix: run feature validation during fix#24

Merged
vincentkoc merged 2 commits into
openclaw:mainfrom
rohitjavvadi:fix/run-feature-validation
May 16, 2026
Merged

fix: run feature validation during fix#24
vincentkoc merged 2 commits into
openclaw:mainfrom
rohitjavvadi:fix/run-feature-validation

Conversation

@rohitjavvadi
Copy link
Copy Markdown
Contributor

Fixes #23

Summary

  • make clawpatch fix use feature-aware validation commands in dry-run and real execution
  • preserve the intended validation order: formatter, targeted feature tests, typecheck, lint, broader tests
  • ignore empty feature test commands and deduplicate repeated validation commands
  • add workflow regression tests for dry-run output, failed targeted validation, empty-command filtering, dedupe, and command ordering

Why

clawpatch show already surfaced feature-specific validation commands, but clawpatch fix only ran global configured commands. A fix could therefore be recorded as applied without running the targeted test attached to that feature.

Validation

  • corepack pnpm typecheck
  • corepack pnpm lint
  • corepack pnpm format:check
  • corepack pnpm test
  • corepack pnpm build
  • Claude Review approved the final diff
  • three independent edge-case/robustness reviews found no blocking issues

@vincentkoc vincentkoc force-pushed the fix/run-feature-validation branch from 4c8169a to 6160c97 Compare May 16, 2026 18:54
@vincentkoc vincentkoc merged commit 7bd29b8 into openclaw:main May 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix skips feature-specific validation commands

2 participants