fix: enable protected-branch automerge requests#237
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed May 31, 2026, 7:14 AM ET / 11:14 UTC. Summary Reproducibility: yes. from source, but not from a full authorized live target: current main blocks Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this after an authorized protected-branch run shows Do we have a high-confidence way to reproduce the issue? Yes from source, but not from a full authorized live target: current main blocks Is this the best way to solve the issue? Yes for the code direction: using GitHub auto-merge only for AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against c91028476c06. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Route approved ClawSweeper automerge through GitHub auto-merge so protected-branch BLOCKED state can become a waiting autoMergeRequest instead of a hard router block. Report open PRs with an autoMergeRequest as waiting/enabled, while preserving the existing executed response when GitHub merges immediately. Tests: nix shell nixpkgs#nodejs_24 nixpkgs#pnpm -c pnpm run check
c053be8 to
8779174
Compare
|
@clawsweeper re-review Updated the branch and PR body after the first review:
|
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Human written summary:
The intent of this change is, as written by a human:
The rest of this PR was written by GPT-5, running in the Codex desktop harness. Full environment + prompt history appear at the end.
Changes
gh pr merge --auto.BLOCKEDmerge-state allowance across the comment router and automerge shepherd so post-repair continuations can reach the router.--autois only added formergeStateStatus: BLOCKED.autoMergeRequestas waiting/enabled instead of claiming it merged.Tests
nix shell nixpkgs#nodejs_24 nixpkgs#pnpm -c pnpm run build:repair- passed.nix shell nixpkgs#nodejs_24 nixpkgs#pnpm -c pnpm run test:repair -- --test-name-pattern 'automerge shepherd|automerge merge args|automerge merge states|comment-router-core'- passed; the runner executed the full repair suite, 437 tests passed.nix shell nixpkgs#nodejs_24 nixpkgs#pnpm -c pnpm run format- passed.nix shell nixpkgs#nodejs_24 nixpkgs#pnpm -c pnpm run check- passed.repair-comment-router.ymlfrom this branch againstopenclaw/telecrawl#4; run https://github.com/openclaw/clawsweeper/actions/runs/26710838589 completed successfully withCLAWSWEEPER_ALLOW_MERGE=1, app credentials,merge_state_status: BLOCKED, and 6/6 green checks. It did not reachgh pr merge --autobecause the Telecrawl automerge comments were not maintainer-authorized for that target: the router saw repository permissionreadand author associationCONTRIBUTOR. That is an external authorization blocker for this proof target, not the merge-state bug fixed here.Risks
--match-head-commit.Follow-ups
autoMergeRequeststate on a maintainer-authorized protected-branch target before merging if ClawSweeper still requires live behavior proof.Prompt History
Environment
Harness: Codex desktop
Model: GPT-5
Thinking level: not exposed by harness
Terminal: zsh
System: macOS, local checkout
/Users/josh/code/research/clawsweeperPrompts
Well, wait a second. If ClawSweeper is broken, why aren't we creating a PR to fix it?