fix: let maintainer automerge resume paused PRs#385
Conversation
|
Codex review: passed. Reviewed July 2, 2026, 2:46 AM ET / 06:46 UTC. Summary Reproducibility: yes. by source inspection: current main blocks paused mode replay whenever a pause label and existing mode status response are both present, before the router can remove pause labels for a later maintainer command. I did not execute the router because this review is read-only. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the guarded router change after maintainers accept command-based resume as the desired pause policy, preserving fail-closed behavior when pause history is missing. Do we have a high-confidence way to reproduce the issue? Yes by source inspection: current main blocks paused mode replay whenever a pause label and existing mode status response are both present, before the router can remove pause labels for a later maintainer command. I did not execute the router because this review is read-only. Is this the best way to solve the issue? Yes, this is a narrow fix for the stated resume path: authorization is resolved before the bypass, trusted-bot replay remains blocked, and only newer autofix/automerge commands after a recorded pause can resume the lane. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 0c85aae0ecbc. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper automerge |
|
🦞✅ Source: What merged:
Automerge notes:
The automerge loop is complete. Automerge progress:
|
Summary
Fix the comment router pause guard so a fresh maintainer
@clawsweeper automergecommand can resume a PR after@clawsweeper stopleft it paused for human review.Root Cause
openclaw/openclaw#93209 exposed a replay-guard bug in the automerge command router. The PR had an older shared automerge status comment, then a later
@clawsweeper stopremovedclawsweeper:automergeand addedclawsweeper:human-review. When a maintainer later posted a new@clawsweeper automerge,pausedModeStatusBlocksReplay()saw the pause label plus the old status comment and classified the fresh maintainer command as skipped. That meant bothapproveandautomergecould fail to recover the paused lane without manual label removal.Changes
Validation
pnpm run build:repair && node --test test/repair/comment-router-core.test.tspnpm run check