fix(embed): truncate inputs over 8192-token limit#4
Closed
RomneyDa wants to merge 1 commit into
Closed
Conversation
Threads with bodies past OpenAI's embedding cap (e.g. openclaw/openclaw#27137, 10k tokens) failed the entire batch. Cap embedding input to 24576 runes so 3 chars/token-floor content stays under 8192 tokens. Closes openclaw#2. Per-model dynamic detection tracked in openclaw#3.
Member
Author
|
@vincentkoc fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
embeddingTextForBasisand e2e test with a fake OpenAI server that returns the real 400 error.Closes #2. Per-model dynamic detection tracked in #3.
Test plan
go test ./...(full suite green)