Skip to content

fix(calendar): support --reminder popup:0m#316

Merged
steipete merged 2 commits intoopenclaw:mainfrom
salmonumbrella:fix/calendar-reminder-zero-302
Mar 8, 2026
Merged

fix(calendar): support --reminder popup:0m#316
steipete merged 2 commits intoopenclaw:mainfrom
salmonumbrella:fix/calendar-reminder-zero-302

Conversation

@salmonumbrella
Copy link
Copy Markdown
Contributor

@salmonumbrella salmonumbrella commented Feb 18, 2026

Summary

  • force-send EventReminder.Minutes when value is 0 so Calendar API receives an explicit 0-minute override
  • add regression test for buildReminders([]string{"popup:0m"})

Why

calendar create --reminder popup:0m currently fails with:
Google API error (400 required): Missing override reminder minutes.

Root cause: Minutes is omitted by omitempty when 0, so the API sees an override reminder without minutes.

Fixes #302

Notes

  • includes a small compile-fix commit (contacts_crud helper signature types) so this branch remains CI-green against current main.

Testing

  • go test ./...

@steipete steipete force-pushed the fix/calendar-reminder-zero-302 branch from f4122d1 to 9cd6169 Compare March 8, 2026 00:38
@steipete
Copy link
Copy Markdown
Collaborator

steipete commented Mar 8, 2026

Landed via temp rebase onto main.

  • Gate: make fmt && go test ./internal/cmd -run 'TestBuildReminders|TestCalendarCreateCmd_ReminderPopupZeroForceSendsMinutes|TestCalendarUpdateCmd_SendUpdates' && make lint && make test && make worker-ci && make ci
  • Land commit: 9cd6169
  • Merge commit:

Thanks @salmonumbrella!

@steipete steipete merged commit b8df361 into openclaw:main Mar 8, 2026
2 of 5 checks passed
@steipete
Copy link
Copy Markdown
Collaborator

steipete commented Mar 8, 2026

Merge finalized after GitHub recalculated mergeability post-force-push.

Thanks again @salmonumbrella!

klodr pushed a commit to klodr/gogcli that referenced this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

calendar create --reminder popup:0m fails with "Missing override reminder minutes" (minutes=0 likely omitted in JSON)

2 participants