fix(calendar): support --reminder popup:0m#316
Merged
steipete merged 2 commits intoopenclaw:mainfrom Mar 8, 2026
Merged
Conversation
f4122d1 to
9cd6169
Compare
Collaborator
|
Landed via temp rebase onto main.
Thanks @salmonumbrella! |
Collaborator
|
Merge finalized after GitHub recalculated mergeability post-force-push. Thanks again @salmonumbrella! |
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventReminder.Minuteswhen value is0so Calendar API receives an explicit 0-minute overridebuildReminders([]string{"popup:0m"})Why
calendar create --reminder popup:0mcurrently fails with:Google API error (400 required): Missing override reminder minutes.Root cause:
Minutesis omitted byomitemptywhen0, so the API sees an override reminder without minutes.Fixes #302
Notes
contacts_crudhelper signature types) so this branch remains CI-green against currentmain.Testing
go test ./...