feat(docs): support markdown in docs update#642
Conversation
|
Codex review: needs maintainer review before merge. Reviewed May 30, 2026, 5:18 PM ET / 21:18 UTC. Summary Reproducibility: not applicable. as a feature PR rather than a bug report; source inspection confirms current main lacks the requested flags and the PR adds focused test coverage for the new paths. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Land the narrow Docs update surface once normal CI and maintainer review are satisfied, keeping the explicit UTF-16 range documentation so callers understand the sharp replacement primitive. Do we have a high-confidence way to reproduce the issue? Not applicable as a feature PR rather than a bug report; source inspection confirms current main lacks the requested flags and the PR adds focused test coverage for the new paths. Is this the best way to solve the issue? Yes; reusing the existing markdown renderer and adding delete-plus-insert range replacement inside AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against b77da7ff559f. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg ✨ Hatched: 🥚 common Frosted Crabkin Hatch commandComment Hatchability rules:
Rarity: 🥚 common. What is this egg doing here?
|
|
Really nice direction — Proposed surface: Semantics: delete content in Why it pairs with
Use cases (the ones I keep hitting):
Happy to test on a live doc once it lands. Thanks again for picking this up. |
|
Added this in 001a1f9. The updated PR now supports both plain and markdown range replacement on gog docs update <id> --replace-range START:END --text replacement
gog docs update <id> --markdown --replace-range START:END --file body.mdSemantics are the proposed low-level primitive: callers provide the UTF-16 Docs API range; gog deletes that range and inserts the replacement at START. It composes with Validation run:
|
|
Also updated the repo-local agent skill docs in
|
Summary
Testing