feat(comments): add since filter#704
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 7, 2026, 12:29 AM ET / 04:29 UTC. Summary Reproducibility: not applicable. as a bug reproduction; this is a feature PR. Source inspection of current main shows no Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Land this PR, or an equivalent narrow implementation, after normal checks while keeping Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction; this is a feature PR. Source inspection of current main shows no Is this the best way to solve the issue? Yes, this is the narrow maintainable path: one shared RFC3339 validator and one shared Drive comments API path avoid divergent Drive and Docs implementations. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 3d5c9cef65fa. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
Fixes #688.
Adds
--since <RFC3339>to both comment list surfaces:gog drive comments list <fileId> --since <timestamp>gog docs comments list <docId> --since <timestamp>The flag is validated locally as RFC3339/RFC3339Nano with timezone and is passed to Drive Comments
startModifiedTime, preserving existing paging,--all,--include-resolved,--include-quoted, and output behavior.Proof
Local:
go test ./internal/cmd -run 'TestDriveCommentsList|TestDocsCommentsList|TestDriveComments_ValidationErrors|TestDocsComments_ValidationErrors'go test ./internal/cmd/...make docs-commandsmake ci/Users/steipete/Projects/agent-scripts/skills/autoreview/scripts/autoreview --mode local→ clean, no accepted/actionable findingsgit diff --checkLive E2E with
clawdbot@gmail.com:auth list --checkreportsvalid:true./tmp/gog-comments-since.docs comments listreturneddocs_all_count:1docs comments list --since 2020-01-01T00:00:00Zreturneddocs_since_past_count:1docs comments list --since <future RFC3339>returneddocs_since_future_count:0drive comments list --since 2020-01-01T00:00:00Zreturneddrive_since_past_count:12026-06-04T10:00:00was rejected withinvalid --sincedrive get --fields id,name,trashed:cleanup_trashed:true.