fix(docs): preserve tab markdown nested lists#707
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 7, 2026, 2:58 AM ET / 06:58 UTC. Summary Reproducibility: yes. from source and the linked public repro, but not from an executed local test in this read-only review. Current main parses list markers only at column 0 and formats parsed list items without nested-level handling. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused parser/formatter and tab-export fix after normal CI and maintainer review, leaving #696 to close via the linked merge. Do we have a high-confidence way to reproduce the issue? Yes from source and the linked public repro, but not from an executed local test in this read-only review. Current main parses list markers only at column 0 and formats parsed list items without nested-level handling. Is this the best way to solve the issue? Yes. The PR repairs the existing tab-local markdown conversion with Docs leading-tab list semantics and fixes tab export metadata resolution rather than adding a new mode or config surface. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 490a9cb3556f. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Landed in e0926bc. Proof:
Caveat: #696 mentioned 10 levels, but current Google Docs API |
Summary
docs write --replace --markdown --tab.docs export --tabtab resolution by requesting tab metadata withincludeTabsContent=trueand a narrow tab field mask.Fixes #696.
Proof
go test ./internal/cmd -run 'TestParseMarkdown_NestedLists|TestParseMarkdown_NestedListsFourSpaceBlock|TestParseMarkdown_IndentedListMarkerWithoutParent|TestParseMarkdown_TopLevelListResetsNestedIndentStack|TestMarkdownToDocsRequests_NestedLists|TestMarkdownToDocsRequests_MixedListChildrenStayNested|TestDocsWrite_MarkdownReplaceWithTab_NestedLists|TestMarkdownToDocsRequests_AppendBulletsAndCode|TestResolveTabID' -count=1go test ./internal/cmd/...make ci/Users/steipete/Projects/agent-scripts/skills/autoreview/scripts/autoreview --mode localclean: no accepted/actionable findingsclawdbot@gmail.com: scratch doc1u395M6fn_9xohN2K-rKymuTCr3SOfQzjm1DSBsFlUQs, tabt.2u7ivet9p9b7;raw_levels_ok:true,raw_max_depth_level:8,raw_bullet_count:21,export_nested_ok:true,cleanup_trashed:true,gog_pr696_e2e_rc:0.