Skip to content

fix(gmail): include display name in From header for primary account#93

Merged
steipete merged 2 commits intoopenclaw:mainfrom
salmonumbrella:fix/gmail-send-display-name
Jan 21, 2026
Merged

fix(gmail): include display name in From header for primary account#93
steipete merged 2 commits intoopenclaw:mainfrom
salmonumbrella:fix/gmail-send-display-name

Conversation

@salmonumbrella
Copy link
Copy Markdown
Contributor

Summary

  • When --from is not specified, now looks up the primary account's send-as settings
  • Includes display name in From header if configured (e.g., John Doe <john@example.com>)
  • Gracefully falls back to plain email if lookup fails or no display name set

Fixes #87

Test plan

  • All tests pass (go test ./...)
  • Build succeeds (go build ./...)
  • Added 3 new tests covering: display name present, absent, and API failure

🤖 Generated with Claude Code

@steipete
Copy link
Copy Markdown
Collaborator

Thanks!

salmonumbrella and others added 2 commits January 21, 2026 08:16
When sending an email via `gog gmail send` without the --from flag, the
From header now includes the display name from the primary account's
send-as settings, if configured. Previously, only the email address was
included.

Before: From: user@example.com
After:  From: John Doe <user@example.com>

The fix gracefully handles cases where:
- The primary account has no display name configured (uses plain email)
- The send-as lookup fails (uses plain email, no error)

Fixes openclaw#87

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@steipete steipete force-pushed the fix/gmail-send-display-name branch from dfe0d8f to 922e3c4 Compare January 21, 2026 08:17
@steipete steipete merged commit 548fdd2 into openclaw:main Jan 21, 2026
4 checks passed
@steipete
Copy link
Copy Markdown
Collaborator

Landed via temp rebase onto main.\n\n- Gate: pnpm lint && pnpm build && pnpm test\n- Land commit: 922e3c4\n- Merge commit: 548fdd2\n\nThanks @salmonumbrella!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gmail send doesn't include display name in From header

2 participants