Skip to content

[codex] fix sync skip flags#2

Closed
scoootscooob wants to merge 1 commit into
openclaw:mainfrom
scoootscooob:codex/fix-sync-skip-flags
Closed

[codex] fix sync skip flags#2
scoootscooob wants to merge 1 commit into
openclaw:mainfrom
scoootscooob:codex/fix-sync-skip-flags

Conversation

@scoootscooob
Copy link
Copy Markdown
Contributor

Summary

Fixes sync option handling so CLI opt-out flags such as --no-transcripts and --no-panels are preserved when sync defaults are applied.

Root cause

parseSyncOptions previously encoded --no-transcripts by setting IncludeTranscripts to false, but syncer.Run later ORed that value with config defaults. When the config default enabled transcripts, the explicit CLI opt-out was overwritten.

Changes

  • Add explicit skip fields to sync options for transcripts and panels.
  • Apply config defaults only when the corresponding skip flag is not set.
  • Add CLI parser coverage for both skip flags.
  • Add a desktop-cache regression test proving SkipTranscripts prevents transcript archival even when config defaults enable transcripts.

Validation

  • make test
  • Manual desktop-cache bulk test with 48 synthetic notes and 144 transcript chunks
  • Confirmed sync --source desktop-cache --no-transcripts --no-panels reports transcripts: 0 after the fix

@scoootscooob scoootscooob marked this pull request as ready for review May 6, 2026 08:53
@vincentkoc
Copy link
Copy Markdown
Member

Thanks for the fix. I re-verified this against current openclaw/graincrawl main and found the original branch had gone stale after the org/module-path migration: the new regression test still imported github.com/vincentkoc/graincrawl/..., so GOWORK=off go test ./... failed on the PR as-is.

I landed the same behavior fix via #10 with the OpenClaw import correction and a changelog line. Verification on the replacement PR:

  • autoreview helper from openclaw/openclaw: clean, no accepted/actionable findings
  • GOWORK=off go mod tidy
  • git diff --exit-code -- go.mod go.sum
  • GOWORK=off go vet ./...
  • GOWORK=off go test ./...
  • GOWORK=off go run golang.org/x/vuln/cmd/govulncheck@v1.3.0 ./...

Closing this PR as superseded by #10 / merge commit 51f1a41.

@vincentkoc vincentkoc closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants