[codex] fix sync skip flags#2
Closed
scoootscooob wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for the fix. I re-verified this against current I landed the same behavior fix via #10 with the OpenClaw import correction and a changelog line. Verification on the replacement PR:
Closing this PR as superseded by #10 / merge commit 51f1a41. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes sync option handling so CLI opt-out flags such as
--no-transcriptsand--no-panelsare preserved when sync defaults are applied.Root cause
parseSyncOptionspreviously encoded--no-transcriptsby settingIncludeTranscriptsto false, butsyncer.Runlater ORed that value with config defaults. When the config default enabled transcripts, the explicit CLI opt-out was overwritten.Changes
SkipTranscriptsprevents transcript archival even when config defaults enable transcripts.Validation
make testsync --source desktop-cache --no-transcripts --no-panelsreportstranscripts: 0after the fix