Skip to content

fix: rearm watch sidecars#130

Merged
steipete merged 1 commit into
mainfrom
fix/watch-sidecar-rearm
May 28, 2026
Merged

fix: rearm watch sidecars#130
steipete merged 1 commit into
mainfrom
fix/watch-sidecar-rearm

Conversation

@steipete
Copy link
Copy Markdown
Collaborator

Summary

  • re-arm watcher file sources when chat.db, chat.db-wal, or chat.db-shm is replaced or disappears
  • add a parent-directory source so WAL/SHM creation after checkpoint rotation refreshes watched paths
  • document the directory watch and fallback re-arm behavior

Fixes #126.

Proof

  • swift test --filter MessageWatcherTests
  • swift test --filter 'MessageWatcherTests|RPCServerTests|RPCBridgeMessageHandlersTests'
  • make lint (passes; existing warning-only lint debt remains)
  • /Users/steipete/Projects/agent-scripts/skills/autoreview/scripts/autoreview --mode local --parallel-tests "swift test --filter MessageWatcherTests" clean
  • make test still fails locally on existing Full Disk Access dependent live Messages DB send-command tests; the new watcher regression passes inside that run

@clawsweeper
Copy link
Copy Markdown

clawsweeper Bot commented May 28, 2026

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix: rearm watch sidecars This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete steipete merged commit 915d36b into main May 28, 2026
2 checks passed
@steipete steipete deleted the fix/watch-sidecar-rearm branch May 28, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

watch/rpc silently stops detecting new messages after WAL checkpoint (sidecar rotation) on busy chat.db; poll-fallback doesn't re-arm

1 participant