refactor: extract CopyDiagnostic helper for diagnostic copy methods#336
Merged
shanselman merged 1 commit intoMay 13, 2026
Merged
Conversation
Nine structurally identical Copy* methods (CopySupportContext, CopyDebugBundle, CopyBrowserSetupGuidance, CopyPortDiagnostics, CopyCapabilityDiagnostics, CopyNodeInventory, CopyChannelSummary, CopyActivitySummary, CopyExtensibilitySummary) each repeated the same DataPackage + Clipboard.SetContent boilerplate alongside identical try/catch logging. This replaces all nine bodies with a single private CopyDiagnostic(string label, Func<GatewayCommandCenterState, string>) helper and reduces each method to an expression-bodied one-liner. No observable behavior change: log messages, clipboard content, error handling, and method signatures (exposed as Action delegates in DeepLinkActions) are all preserved exactly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Fantastic! Thanks for preventing slop @AlexAlves87 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App.xaml.cshad nine diagnostic copy methods that each repeated thesame 13-line body: build a
DataPackage, call the appropriateCommandCenterTextHelperformatter, write to clipboard, and log successor failure. This extracts that repeated structure into a single private
CopyDiagnostichelper and reduces each method to a one-liner.What changed
CopyDiagnostic(string label, Func<GatewayCommandCenterState, string> format)as a private instance method inApp.xaml.csCopyTextToClipboardstatic already present in the fileActiondelegates inDeepLinkActions)Testing
dotnet build src/OpenClaw.Tray.WinUI/OpenClaw.Tray.WinUI.csproj -r win-x64 --nologoNotes
No behaviour change. The one subtle difference worth noting: exceptions thrown inside
BuildCommandCenterState()are now caught by the helper's try/catch, which was already the case in each of the original per-method try/catch blocks.Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com