Skip to content

Apply A2UI CardBackground theme override#391

Closed
Copilot wants to merge 2 commits into
masterfrom
copilot/deep-review-fix-cardbackground-application
Closed

Apply A2UI CardBackground theme override#391
Copilot wants to merge 2 commits into
masterfrom
copilot/deep-review-fix-cardbackground-application

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

A2UITheme parsed colors.card, but CardRenderer ignored it and always used the default Fluent card background. This made the documented card background theme override a no-op for agent-provided surfaces.

  • Renderer
    • Applies ctx.Theme.CardBackground to the rendered card Border.Background when present.
    • Preserves the existing Fluent resource fallback when no override is provided.
if (ctx.Theme.CardBackground is { } cardBackground)
    border.Background = new SolidColorBrush(cardBackground);
else if (Application.Current.Resources.TryGetValue("CardBackgroundFillColorDefaultBrush", out var bg) && bg is Brush bgBrush)
    border.Background = bgBrush;
  • Coverage
    • Adds a focused A2UI UI test for styles.colors.card rendering as the card border background.

Co-authored-by: shanselman <2892+shanselman@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CardBackground theme override application in CardRenderer Apply A2UI CardBackground theme override May 14, 2026
Copilot AI requested a review from shanselman May 14, 2026 21:26
@shanselman
Copy link
Copy Markdown
Contributor

Closing this automation implementation as stale/superseded after the post-refactor triage. The underlying signal is preserved in #343 and the tracker update in #372: CardBackground is tracked in #372 and has duplicate/stale automation coverage.

@shanselman shanselman closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deep-review] C3: A2UI CardBackground theme override is parsed but never applied

2 participants