[Repo Assist] fix(dispatch): remove empty catch swallows; add SafeDispatch/SafeEventInvoke helpers

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Closes #365

Root Cause

Audit of src/ found two recurring AI-slop patterns:

1. try { DispatcherQueue?.TryEnqueue(...) } catch { } — TryEnqueue returns bool and never throws. The try/catch was doing literally nothing, silently hiding any future exception placed inside the lambda.
2. try { event?.Invoke(...) } catch { } — Silently swallows exceptions thrown by event handlers. Symptoms appear as "activity stream randomly stops updating" with no log entry.

Fix

New helpers (Helpers/SafeDispatch.cs, Helpers/SafeEventInvoke.cs)

// SafeDispatch — extension on DispatcherQueue
public static void SafeEnqueue(this DispatcherQueue? queue, DispatcherQueueHandler action)
    => queue?.TryEnqueue(action);

// SafeEventInvoke — logs instead of swallowing
public static void SafeInvoke<T>(this Action<T>? handler, T arg, IOpenClawLogger? log = null);
public static void SafeInvoke(this Action? handler, IOpenClawLogger? log = null);

HubWindow.xaml.cs

• Removed 15 useless try { DispatcherQueue?.TryEnqueue(...) } catch { } blocks. The dispatcher call is now direct; the two intentional catches (settings save with comment, and the typed catch (Exception ex)) are untouched.

AudioPipeline.cs

• Replaced 11 silent try { DiagnosticMessage?.Invoke(...) } catch { } / try { VoiceActivityChanged?.Invoke(...) } catch { } patterns with SafeInvoke(..., _logger). Exceptions from handlers are now logged at Warn rather than discarded.

Trade-offs

• This is a partial migration (HubWindow + AudioPipeline). The remaining ~80 sites across 39 other files are left for opportunistic follow-up, as the issue proposes.
• SafeEnqueue is thin — it exists as a named intent marker and to make future callers consistent.

Test Status

Linux CI (this run)

• dotnet test OpenClaw.Shared.Tests → 1565 passed, 7 pre-existing failures, 28 skipped ✅
• dotnet test OpenClaw.Tray.Tests → 1165 passed (+9 new), 7 pre-existing failures, 47 skipped ✅
• build.ps1 requires Windows (MakePri.exe); build is infrastructure-limited on Linux — not caused by these changes.

New tests

9 unit tests in SafeEventInvokeTests.cs covering null-safety, single/multi handler invocation, exception containment, and logger integration.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• az667904.vo.msecnd.net
• vortex.data.microsoft.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "az667904.vo.msecnd.net"
    - "vortex.data.microsoft.com"

See Network Configuration for more information.

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@97143ac59cb3a13ef2a77581f929f06719c7402a