refactor: extract OpenClaw.Connection project for independent testability

[ranjeshj]

Summary

Extracts gateway connection management logic from \OpenClaw.Tray.WinUI\ into a new \OpenClaw.Connection\ project (
et10.0), enabling independent testing without WinUI dependencies.

Phase 1: Project extraction (30 files)

• \GatewayConnectionManager, \GatewayRegistry, \ConnectionStateMachine, \CredentialResolver, \NodeConnector, \SshTunnelService/Manager, \SetupCodeDecoder, and all connection interfaces/DTOs/enums
• New \OpenClaw.Connection.Tests\ project with 215 tests
• Refactored \InteractiveGatewayCredentialResolver\ to drop \SettingsManager\ dependency
• Removed \SshTunnelService.EnsureStarted(SettingsManager)\ overload

Phase 2: Architectural cleanup

• Deleted legacy \GatewayCredentialResolver\ (zero production callers)
• \OperatorClientChangedEventArgs\ now exposes \IOperatorGatewayClient\ (interface, not concrete)
• Extracted \SshTunnelSnapshot\ — read-only record decouples UI from mutable service state
• Created \ConnectionSettingsSnapshot\ — eliminates \SettingsData\ dependency from Connection layer
• \ConnectionTrigger\ and \RetryPolicy\ made internal (implementation details)

Bug fixes

• Approval command now uses pairing request ID (UUID) with deviceId fallback for older gateways
• \NodePairingRequestId\ cleared when node leaves PairingRequired state (prevents stale reads)
• Added node pairing approval requests to Connection page (was only on Nodes page)
• Warning log added for silent \IOperatorGatewayClient\ to \OpenClawGatewayClient\ cast

Dependency graph

\
OpenClaw.Shared (net10.0) -- transport/protocol
|
OpenClaw.Connection (net10.0) -- connection lifecycle, registry, credentials
|
OpenClaw.Tray.WinUI (net10.0-windows) -- UI app
\\

Validation

• build.ps1 pass
• OpenClaw.Shared.Tests: 1,572 passed
• OpenClaw.Connection.Tests: 215 passed
• OpenClaw.Tray.Tests: 987 passed

[shanselman]

Thanks for doing the connection extraction. The new OpenClaw.Connection project and moved tests validate cleanly locally on top of current master, but I found a few behavior regressions that should be fixed before merge.

Blocking:

1. Dashboard can now put a per-device token in the browser URL. In App.xaml.cs, OpenDashboard() now uses TryResolveChatCredentials() and appends any non-bootstrap token. Before this PR, the dashboard only appended GatewayRecord.SharedGatewayToken; if the active gateway had only a paired device token, no query token was added. With this change, a per-device token can land in browser history/referrers and may not match the dashboard HTTP auth contract. Please only append token= for CredentialResolver.SourceSharedGatewayToken; otherwise route to Connection settings or open without a token intentionally.

2. Direct Connect no longer rolls back on async connection failure/timeout. ConnectionPage.OnDirectConnect() still saves/activates the new record and clears stored tokens before connecting, but the previous wait loop for Connected/PairingRequired/Error was removed. GatewayConnectionManager.ConnectAsync() starts the actual websocket connect fire-and-forget, so auth failures/timeouts won’t throw back to the catch block. A mistyped token can replace a working active gateway and leave the user stranded. Please restore outcome-aware rollback, or expose/use a manager API that returns a definitive connect result before committing the state.

3. Disabling SSH tunnel leaves stale tunnel error/status. The old SshTunnelService.EnsureStarted(SettingsManager) reset LastError = null and Status = NotConfigured when UseSshTunnel was false. The new inline EnsureSshTunnelStarted() path only calls Stop(), which can leave a previous failed tunnel surfaced in diagnostics/UI after the user turns SSH off. Please restore the reset semantics.

Also worth fixing in the same pass: the browser-proxy port-skip warning from the old SSH helper was dropped, and NodeConnector.NodeDeviceId changed from ShortDeviceId to FullDeviceId; if full IDs are intentional for approval fallback, the Connection page display should probably truncate the value while preserving the full approval ID.

Local current-master validation passed in D:\github\moltbot-windows-hub.pr409-review: ./build.ps1; OpenClaw.Connection.Tests 215/215; Shared 1572/1600 with 28 skipped; Tray 987/987.

[shanselman]

Maintainer-side follow-up c446ffd addresses the requested blockers: dashboard query tokens are limited to shared gateway tokens, Direct Connect waits for a terminal connected/pairing/error/timeout outcome before keeping the new active record, and disabling SSH resets stale tunnel status/error. Added regression coverage for the token condition, Direct Connect wait path, and SSH reset.\n\nValidated in \D:\github\moltbot-windows-hub.pr409-fix: .\build.ps1; Connection tests 216/216; Shared tests 1572/1600 with 28 skipped; Tray tests 989/989.