[Repo Assist] fix(mcp): add missing tool descriptions for location.get, device.info, device.status, browser.proxy#448
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
…, device.status, browser.proxy Issue #351 was closed but the four undescribed tools were never added to CommandDescriptions in McpToolBridge.cs or skill.md. MCP clients and the local winnode.exe CLI now see the correct parameter shapes and return types for all four tools. Changes: - McpToolBridge.cs: add location.*, device.*, browser.* CommandDescriptions - skill.md: add Location, Device, and Browser control sections with full parameter docs and privacy notes The existing SkillMdDriftTests suite verifies that every command in CommandDescriptions has a matching H3 heading in skill.md — all 115 tests pass with this change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Issue #351 was closed as "completed" but the actual code fix was never applied. Four capabilities registered with
WindowsNodeClient—location.get,device.info,device.status, andbrowser.proxy— remain absent from bothMcpToolBridge.CommandDescriptionsandskill.md.Without these entries, MCP clients and
winnode.exe --command <cmd>calls returnUnknown toolfor all four commands, and agent cold-start for these tools shows no parameter schema.Root Cause
McpToolBridge.KnownCommands(used bytools/list) is derived entirely fromCommandDescriptions.Keys. Any capability command missing from that dictionary is invisible to MCP clients, even thoughNodeService.csfully registers and dispatches those commands.The
SkillMdDriftTeststest only checks symmetry betweenskill.mdandCommandDescriptions— it cannot catch "missing from both", which is exactly what happened here.Fix
McpToolBridge.cs: addedCommandDescriptionsentries forlocation.get,device.info,device.status, andbrowser.proxywith full parameter and return-type documentation.skill.md: added three new sections —## Location (location.*),## Device (device.*), and## Browser control proxy (browser.*)— each with### <command>sub-headings that the drift test enforces.Trade-offs
The
device.statusdescription includes a privacy note about battery/network/disk exposure. No behaviour change — only documentation.Test Status