Clean up Cron page UI to follow Fluent guidelines#512
Conversation
- Remove emoji from page title, preset buttons, empty state, status badges, and toggle labels; render via FluentIconCatalog instead. Add FluentIconCatalog.Cron (Calendar, U+E787). - Move Cron item out of Advanced submenu to top-level Gateway section, directly above Advanced, and gate its visibility on gateway-connected state alongside the other gateway pages. - Replace per-job Enable/Disable button with a right-aligned ToggleSwitch in the card header; remove redundant action button and dead VM members. - Use theme tokens for status colors (SystemFillColorSuccess/Critical/Attention/Neutral, LayerFillColorDefaultBrush) instead of hard-coded ARGB literals; fixes green-on-green legibility and removes saturated pill backgrounds. - Switch input labels to sentence-case BodyStrongTextBlockStyle and other typography tokens; remove literal FontSize/FontWeight. - Fix new-job form overlapping page content: name the row-defined inner Grid (PageRootGrid) so JobFormPanel is reparented into the correct Grid with Grid.Row=2 honored. - Add card stroke and use LayerFillColorDefaultBrush for the opaque create/edit form surface. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Codex review: needs real behavior proof before merge. Latest ClawSweeper review: 2026-05-22 20:55 UTC / May 22, 2026, 4:55 PM ET. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: not applicable. this is a UI cleanup PR rather than a bug report with a failing behavior to reproduce. Source inspection and the screenshot are enough to evaluate the changed surface, but the form state still needs visual proof. PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review findings
Review detailsBest possible solution: Land after the small runtime label fix, maintainer acceptance of the top-level Cron nav placement, and redacted visual proof of the create/edit form state. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a UI cleanup PR rather than a bug report with a failing behavior to reproduce. Source inspection and the screenshot are enough to evaluate the changed surface, but the form state still needs visual proof. Is this the best way to solve the issue? Mostly yes: using Fluent resources, a header ToggleSwitch, and the named PageRootGrid is a narrow maintainable cleanup. The runtime form labels should match the sentence-case direction, and maintainers still need to accept the nav placement. Label changes:
Label justifications:
Full review comments:
Overall correctness: patch is correct What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against ece297ad0080. |
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
Cleans up the Cron Jobs page to follow Fluent / WinUI guidelines (UI-only).
Changes
AccentButtonStyle; status dot usesSystemFillColorSuccess/NeutralBrush.MaxWidth=900with growing side bars, matching Permissions/Sessions/etc.ToggleSwitchin the header; removed redundant detail-panel button and dead VM members; added card stroke for crisper edges.SystemFillColorSuccess/Critical/Attention/Neutralso the success text is readable (fixes green-on-green).LayerFillColorDefaultBrush) and reparents into the row-definedPageRootGridso it no longer overlaps the job list.FluentIconCatalog.Cron(Calendar, U+E787); removed remaining emojis from page title, preset buttons, empty state, status badges, and toggle labels.BodyStrongTextBlockStyleand other typography tokens; removed literalFontSize/FontWeight.Validation
./build.ps1