fix(matrix): handle downloadContent returning {data, contentType} object#11902
Draft
jacoblyles wants to merge 1 commit intoopenclaw:mainfrom
Draft
fix(matrix): handle downloadContent returning {data, contentType} object#11902jacoblyles wants to merge 1 commit intoopenclaw:mainfrom
jacoblyles wants to merge 1 commit intoopenclaw:mainfrom
Conversation
The @vector-im/matrix-bot-sdk downloadContent method returns
{data: Buffer, contentType: string} rather than a raw Buffer.
The existing code passed this object directly to Buffer.from(),
causing ERR_INVALID_ARG_TYPE for all inbound Matrix media.
Also extracts contentType from the response header for proper
MIME type detection.
bfc1ccb to
f92900f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
@vector-im/matrix-bot-sdk'sdownloadContentreturns{data: Buffer, contentType: string}, not a rawBuffer. The existing code passed this object directly toBuffer.from(), causingERR_INVALID_ARG_TYPEfor all inbound Matrix media (images, files, audio, video).Fix
Unwrap the
dataproperty from the response before creating the Buffer. Also extractscontentTypefrom the response for proper MIME type detection.Testing
Verified on a local Synapse homeserver — images sent from Element iOS now download and are passed to the agent correctly.