tui: recover local no-output runs via history fallback#15518
tui: recover local no-output runs via history fallback#15518TsekaLuk wants to merge 1 commit intoopenclaw:mainfrom
Conversation
|
CI note: a bunch of checks are marked cancelled (android/checks-windows/release-check/checks/macos/build-artifacts/changed-scope/install-smoke/label/label-issues). This looks like the workflow runs were cancelled rather than a code failure. I don't have admin rights to rerun from CLI; maintainer rerun on branch One of the cancelled runs: https://github.com/openclaw/openclaw/actions/runs/21991887337 |
|
Hey! 👋 CI is all green on this one. Would you have time to take a look? Happy to make changes if needed. Thanks! |
|
Thanks for the heads up! I don't have admin rights either. Could a maintainer with admin access kindly rerun the failed checks? Thanks! |
bfc1ccb to
f92900f
Compare
|
This pull request has been automatically marked as stale due to inactivity. |
Summary
Fixes a TUI reliability bug where local runs can finalize as
(no output)even though assistant text is persisted shortly after.Code word: lobster-biscuit
Repro Steps
Related reports:
openclaw tuiwith a provider/model that intermittently emits emptychat.finalpayload text.(no output)in TUI.Root Cause
chat.finalcan occasionally arrive without renderable assistant text while transcript persistence catches up moments later. TUI currently finalizes immediately and never retries history for local runs, so users see(no output)until reconnect.Behavior Changes
(no output)and stopReason is noterror, schedule two short history refresh retries (200ms, 1000ms).Codebase and GitHub Search
src/tui/tui-event-handlers.tssrc/tui/tui-stream-assembler.tssrc/tui/tui-formatters.tsMiniMax responses show '(no output)' until TUI restart)[Bug]: no output)Tests
pnpm vitest src/tui/tui-event-handlers.test.ts src/tui/tui-formatters.test.ts --runpnpm checkManual Testing
Prerequisites
Steps
Evidence
(no output)triggers 2 history retries insrc/tui/tui-event-handlers.test.ts.Sign-Off