ci(formal): don't fail on fork PRs when PR comment is blocked#17426
Open
mitre88 wants to merge 3 commits intoopenclaw:mainfrom
Open
ci(formal): don't fail on fork PRs when PR comment is blocked#17426mitre88 wants to merge 3 commits intoopenclaw:mainfrom
mitre88 wants to merge 3 commits intoopenclaw:mainfrom
Conversation
Author
|
Heads up: this fixes a real pain point for fork PRs (e.g. #5507): the "Formal models (informational conformance)" workflow currently fails with 403 (Resource not accessible by integration) when trying to comment from a fork PR.\n\nThis PR makes the comment step fork-safe (skip/continue) so the workflow remains informational and CI stays green.\n\nWould appreciate a quick review/merge 🙏 |
Author
|
Update: CI on this PR was failing with Node OOM in the Linux test matrix (unrelated to the workflow change). I added a small CI tweak to the
This matches the existing Windows/macOS lanes which already set Node heap limits / worker caps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workflow is informational, but currently fails on fork PRs when the comment step hits GitHub's token restrictions (403: "Resource not accessible by integration").
Changes:
issues: writepermission (comment uses the issues API)continue-on-error: trueso the job remains informationalThis should keep CI green for docs-only/community PRs while still uploading the drift artifact.
CONTRIBUTING alignment
pnpm build && pnpm check && pnpm test, say the word and I’ll do it.formal-conformanceworkflow).Greptile Summary
Hardens the formal-conformance workflow to handle fork PRs gracefully by adding proper permissions, fork detection, and error handling for PR comments. Also includes CI memory configuration for 4vCPU runners and test stability improvements for environment variable handling.
Changes:
issues: writepermission to formal-conformance workflow (PR comments use the issues API)continue-on-error: trueto keep the workflow informationalNODE_OPTIONSheap size (6144MB) andOPENCLAW_TEST_WORKERS=2for CI stability on 4vCPU runnersOPENCLAW_STATE_DIRoverride applies to all tests in the fileConfidence Score: 5/5
Last reviewed commit: bd55fa4