Skip to content

ci(formal): don't fail on fork PRs when PR comment is blocked#17426

Open
mitre88 wants to merge 3 commits intoopenclaw:mainfrom
mitre88:chore/formal-conformance-fork-safe
Open

ci(formal): don't fail on fork PRs when PR comment is blocked#17426
mitre88 wants to merge 3 commits intoopenclaw:mainfrom
mitre88:chore/formal-conformance-fork-safe

Conversation

@mitre88
Copy link

@mitre88 mitre88 commented Feb 15, 2026

This workflow is informational, but currently fails on fork PRs when the comment step hits GitHub's token restrictions (403: "Resource not accessible by integration").

Changes:

  • Add issues: write permission (comment uses the issues API)
  • Skip commenting on fork PRs (where token restrictions commonly apply)
  • Wrap comment in try/catch + continue-on-error: true so the job remains informational

This should keep CI green for docs-only/community PRs while still uploading the drift artifact.


CONTRIBUTING alignment

  • Local validation: Not run locally (CI-only). If you want me to run pnpm build && pnpm check && pnpm test, say the word and I’ll do it.
  • Scope: Single theme (make PR comment step fork-safe in formal-conformance workflow).
  • What/Why: See summary above; prevents informational workflow from failing on fork PRs due to token restrictions.
  • AI assistance: Yes — AI-assisted for wording/summary; no additional prompts/logs kept; no local tests run.

Greptile Summary

Hardens the formal-conformance workflow to handle fork PRs gracefully by adding proper permissions, fork detection, and error handling for PR comments. Also includes CI memory configuration for 4vCPU runners and test stability improvements for environment variable handling.

Changes:

  • Added issues: write permission to formal-conformance workflow (PR comments use the issues API)
  • Skip PR comments on fork PRs where token restrictions apply
  • Wrapped comment creation in try/catch with continue-on-error: true to keep the workflow informational
  • Configured NODE_OPTIONS heap size (6144MB) and OPENCLAW_TEST_WORKERS=2 for CI stability on 4vCPU runners
  • Moved test lifecycle hooks outside describe block to ensure OPENCLAW_STATE_DIR override applies to all tests in the file

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are defensive improvements: workflow error handling prevents CI failures on forks, memory configuration addresses known test stability issues, and test refactoring improves scope isolation. No functional logic changes to application code.
  • No files require special attention

Last reviewed commit: bd55fa4

@mitre88
Copy link
Author

mitre88 commented Feb 15, 2026

Heads up: this fixes a real pain point for fork PRs (e.g. #5507): the "Formal models (informational conformance)" workflow currently fails with 403 (Resource not accessible by integration) when trying to comment from a fork PR.\n\nThis PR makes the comment step fork-safe (skip/continue) so the workflow remains informational and CI stays green.\n\nWould appreciate a quick review/merge 🙏

@mitre88
Copy link
Author

mitre88 commented Feb 15, 2026

Update: CI on this PR was failing with Node OOM in the Linux test matrix (unrelated to the workflow change).

I added a small CI tweak to the checks job on Ubuntu runners:

  • NODE_OPTIONS=--max-old-space-size=6144
  • OPENCLAW_TEST_WORKERS=2

This matches the existing Windows/macOS lanes which already set Node heap limits / worker caps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: whatsapp-web Channel integration: whatsapp-web size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments