fix(subagents): restore isInternalMessageChannel guard in resolveAnnounceOrigin#23030
Open
mcinteerj wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(subagents): restore isInternalMessageChannel guard in resolveAnnounceOrigin#23030mcinteerj wants to merge 1 commit intoopenclaw:mainfrom
mcinteerj wants to merge 1 commit intoopenclaw:mainfrom
Conversation
openclaw-barnacle
bot
added
agents
mcinteerj
force-pushed
the
fix/restore-subagent-announce-chain
branch
3 times, most recently
from
e7c74bf to
bbc9554
Compare
mcinteerj
force-pushed
the
fix/restore-subagent-announce-chain
branch
from
bbc9554 to
a11ad5a
Compare
This was referenced Feb 22, 2026
Closed
…unceOrigin Restores the narrower internal-channel guard from PR openclaw#22223 (fe57bea) that was inadvertently reverted by f555835. The original !isDeliverableMessageChannel() check strips the requester's channel whenever it is not in the registered deliverable set. This causes delivery failures for plugin channels whose adapter ID differs from their plugin ID (e.g. "gmail" vs "openclaw-gmail"): the requester origin is discarded and the announce falls back to stale session routes — typically WhatsApp — resulting in a timeout followed by an E.164 format error. Replacing with isInternalMessageChannel() limits stripping to explicitly internal channels (webchat), preserving the requester origin for all external channels regardless of whether they are currently in the deliverable list. Fixes: openclaw#22223 regression introduced in f555835 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
mcinteerj
force-pushed
the
fix/restore-subagent-announce-chain
branch
from
d0ec8f1 to
c92e04c
Compare
3 tasks
mcinteerj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the narrower
isInternalMessageChannel()guard from PR #22223 (fe57bea) that was inadvertently reverted by f555835.The original
!isDeliverableMessageChannel()check strips the requester channel from the announce origin whenever the channel is not in the registered deliverable set. This is overly broad: it discards legitimate requester origins for plugin channels whose adapter ID differs from their plugin ID (e.g."gmail"vs"openclaw-gmail"), causing the announce system to fall back to stale session routes.isInternalMessageChannel()limits stripping to explicitly internal channels (webchat only), preserving requester origin context for all external channels regardless of their position in the deliverable registry.Note
This is a behaviour change for channels not yet in the deliverable list. Acceptable as a no-op if upstream prefers the broader check — the immediate Gmail delivery issue is fixed separately in #23229.
Related
sendAnnouncedelivery hints on channel deliverability, removemethod:sendbypass insendSubagentAnnounceDirectlyisInternalMessageChannelTest plan
🤖 Generated with Claude Code