Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" by papago2355 · Pull Request #2576 · openclaw/openclaw

papago2355 · 2026-01-27T04:36:19Z

1.Fix bugs when provider === "auto" which can lead model end up get ""

Fix to only include remote if you actually have any remote fields. (Is this intentional?)

Have seen many possibly dangerous 'behave as if config is set'

1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?)

Remove redundant hasRemote variable and simplify includeRemote condition.

oxfmt-friendly version

Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

gumadeiras · 2026-01-27T05:28:25Z

Landed via temp rebase onto main.

Gate: pnpm lint && pnpm build && pnpm test
Land commit: $land_sha
Merge commit: $merge_sha

Thanks @papago2355!

papago2355 · 2026-01-28T22:27:37Z

@gumadeiras
It looks like there might be some issues with the workflow configuration.
Is there anything you’d like me to change on my side?

gumadeiras · 2026-01-29T00:43:00Z

which issues are you having?

papago2355 · 2026-01-29T02:02:55Z

which issues are you having?

Several CI checks are failing, mainly around tests and formatting.
Specifically, pnpm test, bunx vitest run, and pnpm format are failing, including on the Windows matrix.
The build and protocol checks are passing, and the failures don’t seem related to the LLM config change in this PR.
Let me know if you want me to dig into any of these failures.

gumadeiras · 2026-01-29T02:19:56Z

The fix was already merged into main 6c451f4
you can ignore the errors on the PR branch here

papago2355 · 2026-01-29T02:22:09Z

Ah, got it now. Thanks for the clarification

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

@papago2355

…o" (openclaw#2576) * Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto" 1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?) * Refactor memory-search.ts to simplify remote checks Remove redundant hasRemote variable and simplify includeRemote condition. * oxfmt-friendly version oxfmt-friendly version * fix: local updates for PR openclaw#2576 Co-authored-by: papago2355 <papago2355@users.noreply.github.com> * fix: memory search auto defaults (openclaw#2576) (thanks @papago2355) --------- Co-authored-by: Gustavo Madeira Santana <gumadeiras@gmail.com> Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

openclaw-barnacle bot added the agents Agent runtime and tooling label Jan 27, 2026

gumadeiras self-requested a review January 27, 2026 04:59

papago2355 and others added 5 commits January 27, 2026 00:21

Fix a subtle bug: modelDefault doesn’t apply when provider === "auto"

6113687

1.Fix bugs when provider === "auto" which can lead model end up get "" 2. Fix to only include remote if you actually have any remote fields. (Is this intentional?)

Refactor memory-search.ts to simplify remote checks

d539dfd

Remove redundant hasRemote variable and simplify includeRemote condition.

oxfmt-friendly version

ce75734

oxfmt-friendly version

fix: local updates for PR openclaw#2576

485a4ab

Co-authored-by: papago2355 <papago2355@users.noreply.github.com>

fix: memory search auto defaults (openclaw#2576) (thanks @papago2355)

b7c37a3

gumadeiras force-pushed the patch-4 branch from 513b6a3 to b7c37a3 Compare January 27, 2026 05:27

gumadeiras merged commit 6c451f4 into openclaw:main Jan 27, 2026
15 of 23 checks passed

papago2355 deleted the patch-4 branch January 29, 2026 02:16

adolago mentioned this pull request Feb 7, 2026

OpenClaw delta (lane 09): Memory + indexing (OpenClaw plugins vs agent-core semantic memory) adolago/zee#232

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto"#2576

Fix a subtle bug: `modelDefault` doesn’t apply when provider === "auto"#2576
gumadeiras merged 5 commits intoopenclaw:mainfrom
papago2355:patch-4

papago2355 commented Jan 27, 2026

Uh oh!

Uh oh!

gumadeiras commented Jan 27, 2026

Uh oh!

papago2355 commented Jan 28, 2026

Uh oh!

gumadeiras commented Jan 29, 2026

Uh oh!

papago2355 commented Jan 29, 2026

Uh oh!

gumadeiras commented Jan 29, 2026

Uh oh!

papago2355 commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

papago2355 commented Jan 27, 2026

Uh oh!

Uh oh!

gumadeiras commented Jan 27, 2026

Uh oh!

papago2355 commented Jan 28, 2026

Uh oh!

gumadeiras commented Jan 29, 2026

Uh oh!

papago2355 commented Jan 29, 2026

Uh oh!

gumadeiras commented Jan 29, 2026

Uh oh!

papago2355 commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants