Configure local Docker gateway defaults#59289
Configure local Docker gateway defaults#59289SuperJohn wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Greptile SummaryThis PR makes two small infrastructure changes: it restricts the Docker gateway and bridge port bindings to Both changes are straightforward and the security tightening of the default bind address is a sensible hardening for local development use. Confidence Score: 5/5
Prompt To Fix All With AIThis is a comment left during a code review.
Path: docker-compose.yml
Line: 25-26
Comment:
**Breaking change for multi-host setups**
Any user who was relying on the previous default of binding to all interfaces (`0.0.0.0`) — e.g. accessing the gateway from another machine on the LAN or from a CI agent — will silently lose connectivity after pulling this change. They would need to set `OPENCLAW_GATEWAY_HOST_IP=0.0.0.0` and `OPENCLAW_BRIDGE_HOST_IP=0.0.0.0` explicitly. Consider noting this in the changelog or an upgrade guide so it doesn't go unnoticed.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Configure local Docker gateway defaults" | Re-trigger Greptile |
| - "${OPENCLAW_GATEWAY_HOST_IP:-127.0.0.1}:${OPENCLAW_GATEWAY_PORT:-18789}:18789" | ||
| - "${OPENCLAW_BRIDGE_HOST_IP:-127.0.0.1}:${OPENCLAW_BRIDGE_PORT:-18790}:18790" |
There was a problem hiding this comment.
Breaking change for multi-host setups
Any user who was relying on the previous default of binding to all interfaces (0.0.0.0) — e.g. accessing the gateway from another machine on the LAN or from a CI agent — will silently lose connectivity after pulling this change. They would need to set OPENCLAW_GATEWAY_HOST_IP=0.0.0.0 and OPENCLAW_BRIDGE_HOST_IP=0.0.0.0 explicitly. Consider noting this in the changelog or an upgrade guide so it doesn't go unnoticed.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docker-compose.yml
Line: 25-26
Comment:
**Breaking change for multi-host setups**
Any user who was relying on the previous default of binding to all interfaces (`0.0.0.0`) — e.g. accessing the gateway from another machine on the LAN or from a CI agent — will silently lose connectivity after pulling this change. They would need to set `OPENCLAW_GATEWAY_HOST_IP=0.0.0.0` and `OPENCLAW_BRIDGE_HOST_IP=0.0.0.0` explicitly. Consider noting this in the changelog or an upgrade guide so it doesn't go unnoticed.
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85842c7a79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ports: | ||
| - "${OPENCLAW_GATEWAY_PORT:-18789}:18789" | ||
| - "${OPENCLAW_BRIDGE_PORT:-18790}:18790" | ||
| - "${OPENCLAW_GATEWAY_HOST_IP:-127.0.0.1}:${OPENCLAW_GATEWAY_PORT:-18789}:18789" |
There was a problem hiding this comment.
Preserve host:port values for OPENCLAW_GATEWAY_PORT
This new port mapping assumes OPENCLAW_GATEWAY_PORT is numeric, but existing setups can legitimately store host:port forms (for example 127.0.0.1:18789), which the codebase explicitly supports when reading .env values (src/config/paths.ts explains this compatibility). With this change, such values render as 127.0.0.1:127.0.0.1:18789:18789, causing docker compose port parsing to fail and preventing the gateway container from starting for upgraded users who already use the old format.
Useful? React with 👍 / 👎.
Summary
Describe the problem and fix in 2–5 bullets:
If this PR fixes a plugin beta-release blocker, title it
fix(<plugin-id>): beta blocker - <summary>and link the matchingBeta blocker: <plugin-name> - <summary>issue labeledbeta-blocker. Contributors cannot label PRs, so the title is the PR-side signal for maintainers and automation.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Root Cause / Regression History (if applicable)
For bug fixes or regressions, explain why this happened, not just what changed. Otherwise write
N/A. If the cause is unclear, writeUnknown.git blame, prior PR, issue, or refactor if known):Regression Test Plan (if applicable)
For bug fixes or regressions, name the smallest reliable test coverage that should have caught this. Otherwise write
N/A.User-visible / Behavior Changes
List user-visible changes (including defaults/config).
If none, write
None.Diagram (if applicable)
For UI changes or non-trivial logic flows, include a small ASCII diagram reviewers can scan quickly. Otherwise write
N/A.Security Impact (required)
Yes/No)Yes/No)Yes/No)Yes/No)Yes/No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
Expected
Actual
Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
Review Conversations
If a bot review conversation is addressed by this PR, resolve that conversation yourself. Do not leave bot review conversation cleanup for maintainers.
Compatibility / Migration
Yes/No)Yes/No)Yes/No)Risks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.